pdavies88
commented
2 years ago Formation Cleanup: Repo veteran-facing-services-tools
Assumptions: if it is not used in any of the following repos it can be removed:
- component-library
- vets-api
- content-build
- vets-api-mockdata
- design-system-dashboard-cli
- vets-design-system-documentation
- formulate
- vets-json-schema
- vagov-content
- vets-website
Overarching I believe this should be a more manual process that using a tool to do this task. There are a lot of references to sub references and I think caution should be used.
Discussion:
- We are bringing in lots of styles from USWDS, do we want to continue to do that?
- We import Foundation but then build our own grid system which is silly. I know both are used in the code but I would like to pick 1 approach instead of 2.
- Cleaning up the jekyll site will actually allow us to remove some of this extra code. Some css classes and files are only being used there and might not actually be needed at all.
- We have a lot of the SVGs in here that we could grab and use in Component Library without having to get Natalie involved, however none of them are being used because we chose to use Font Awesome for everything instead
Epic Cleanup Tickets
Tests and Javascript Cleanup Sub Tickets I think we can completely remove these but this ticket would be to verify that
Fonts and Images Cleanup Sub Tickets There are so many PNGs and SVGs that I can't find referenced as being used anywhere can we clean this up and reduce the bloat
Sass Cleanup Sub Tickets Goal for each ticket is to determine if the css rule is in use and if the file can be condensed. Ideally we should have less files per folder and a clearer idea of what is in each folder. This may require additional comments to show where the css rule is being used
- Base
- Breakpoints
- Element Overrides
- Font Faces Will need to leave in place since Bitter is used in the site
- Functions
- Mixins
- Utils
- Variables
- VA
- Layout
- Flex Grid Seems silly that we have Grid via Foundation 5 and then this and then Foundation 6 has Flex Grid baked in
- Modules If we have a web component for any of these look to see if the react component and the scss could be removed
- Action Link
- Additional Info
- Alert
- Breadcrumbs
- Button
- Dropdown
- Emergency Banner
- External Link
- Form Elements
- Form Process
- Homepage Hero
- Hub Page Link List
- Loading Indicator
- Maintenance Banner
- Megamenu
- Modal
- Nav Linklist
- Nav Next Previous
- Nav Sidebar
- OMB Info
- Overlay
- Process List
- Promo Banner
- Responsive Table
- Search
- Table
- Va Pagination
- Va Tabs
- Site
- Crisis Line
- Footer
- Vet Nav
- Color Palette
- Site Weird that this file is in this subfolder since is doing a ton of imports
- Style
- Utilities
- Normalize
- Other I'd be shocked if these are being used at all
- Shame
- Core and Full and Shared Variables Can these be combined and Site in the Site folder seems to do the same thing
- Icons and Mobile Typography
k80bowman
Description
Develop a list of things we could do to clean up our CSS in https://github.com/department-of-veterans-affairs/veteran-facing-services-tools/tree/master/packages/formation.
Advantages to doing this work:
Details
We are aware that there is some unused CSS in our CSS class library. There might also be some other optimization tasks we could undertake to improve the library that we should document as well.
The point of this ticket is to get a notion of the scale of the amount of work it will take to clean up the CSS library and figure out the best way to break it down.
Acceptance Criteria