Investigate false failures in daily accessibility scan

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:

https://depo-platform-documentation.scrollhelp.site/index.html

278 stars 194 forks source link

Investigate false failures in daily accessibility scan #35837

Closed ddzz closed 2 years ago

ddzz commented 2 years ago

Issue Description

Recently the daily accessibility scan reported failures for accessibility issues that had already been fixed and merged to the master branch. This task is to determine why the daily scan is not picking up the latest changes and lagging behind what's on the master branch..

Tasks

[ ] Determine root cause of false failures in daily accessibility scan.

Acceptance Criteria

[ ] Daily accessibility scan is up-to-date with the master branch.

pjhill commented 2 years ago

Explored possibility of using dev build. That first attempt at a PR didn't work out. PR linked above.

pjhill commented 2 years ago

Discussion with Theo
Working locally
Working on getting it up and running in GHA

pjhill commented 2 years ago

Running one more test
Aiming to complete this today pending successful test

ddzz commented 2 years ago

The Release Tools team mentioned we may want to keep the build as-is, so I'm pausing any more work on this until I get more details on why we should use production assets. My suspicion is that the deployed assets are built differently than the assets from the master commit.

ddzz commented 2 years ago

The PR has been tested and approved, but it can't be merged due to issues with the self-hosted runners used in GitHub Actions. The Infrastructure team is working on a fix.

ddzz commented 2 years ago

The Infrasturcture team has fixed the issues with the self-hosted runners, and the PR has been merged.

pjhill commented 2 years ago

Thanks for investigating this!