search

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 198 forks source link

Improve rspec run time #366

Closed kreek closed 5 years ago

kreek commented 5 years ago

User Story As a VSP developer I want to improve rspec run time so that local spec runs and jenkins builds complete faster.

Acceptance Criteria The following rspec performance issues are addressed:

[TEST PROF INFO] RSpecDissect report

Total time: 03:55.717

Total `let` time: 00:33.696
Total `before(:each)` time: 01:34.424

Top 5 slowest suites (by `let` time):

the API documentation (./spec/request/swagger_spec.rb:23) – 00:04.037 of 00:35.619 (181)
 ↳ subject – 262
 ↳ mhv_user – 189
 ↳ rubysaml_settings – 181
Users::Profile (./spec/services/users/profile_spec.rb:5) – 00:03.616 of 00:04.522 (68)
 ↳ in_progress_form – 69
 ↳ profile – 27
 ↳ subject – 26
EducationForm...arToDateReport (./spec/jobs/education_form/create_daily_year_to_date_report_spec.rb:9) – 00:01.770 of 00:05.164 (7)
 ↳ date – 91
 ↳ subject – 8
 ↳ filename – 3
EducationForm...arToDateReport (./spec/jobs/education_form/create_daily_fiscal_year_to_date_report_spec.rb:9) – 00:01.738 of 00:05.207 (11)
 ↳ date – 91
 ↳ subject – 12
 ↳ filename – 3
Account creation and upgrade (./spec/request/mhv_accounts_request_spec.rb:5) – 00:01.010 of 00:05.232 (89)
 ↳ user – 195
 ↳ mvi_profile – 89
 ↳ terms – 80

Top 5 slowest suites (by `before(:each)` time):

address (./spec/request/address_request_spec.rb:5) – 00:31.718 of 00:32.399 (13)
the API documentation (./spec/request/swagger_spec.rb:23) – 00:03.911 of 00:35.619 (181)
Account creation and upgrade (./spec/request/mhv_accounts_request_spec.rb:5) – 00:02.372 of 00:05.232 (89)
EducationForm...arToDateReport (./spec/jobs/education_form/create_daily_fiscal_year_to_date_report_spec.rb:9) – 00:02.344 of 00:05.207 (11)
EducationForm...arToDateReport (./spec/jobs/education_form/create_daily_year_to_date_report_spec.rb:9) – 00:02.341 of 00:05.164 (7)
[TEST PROF INFO] FactoryDoctor report

Total (potentially) bad examples: 164
Total wasted time: 00:04.056

EducationForm::Forms::VA1995 (./spec/jobs/education_form/forms/va1995_spec.rb:5) (1 record created, 00:00.019)
  converts internal keys to text (./spec/jobs/education_form/forms/va1995_spec.rb:19) – 1 record created, 00:00.019

CentralMail::SubmitSavedClaimJob (./spec/jobs/central_mail/submit_saved_claim_job_spec.rb:5) (2 records created, 00:00.093)
  should generate the metadata (./spec/jobs/central_mail/submit_saved_claim_job_spec.rb:124) – 1 record created, 00:00.062
  should generate metadata with 00000 for zipcode (./spec/jobs/central_mail/submit_saved_claim_job_spec.rb:119) – 1 record created, 00:00.031

EVSSClaimsSyncStatusTracker (./spec/models/evss_claims_sync_status_tracker_spec.rb:5) (4 records created, 00:00.027)
  writes to redis (./spec/models/evss_claims_sync_status_tracker_spec.rb:14) – 2 records created, 00:00.014
  writes to redis (./spec/models/evss_claims_sync_status_tracker_spec.rb:14) – 2 records created, 00:00.013

notifications (./spec/request/notifications_request_spec.rb:5) (2 records created, 00:00.033)
  should return a 422 unprocessable entity (./spec/request/notifications_request_spec.rb:115) – 2 records created, 00:00.033

EducationBenefitsClaimSerializer (./spec/serializers/education_benefits_claim_serializer_spec.rb:5) (5 records created, 00:00.130)
  should include id (./spec/serializers/education_benefits_claim_serializer_spec.rb:11) – 1 record created, 00:00.028
  should include form (./spec/serializers/education_benefits_claim_serializer_spec.rb:16) – 1 record created, 00:00.023
  should include confirmation_number (./spec/serializers/education_benefits_claim_serializer_spec.rb:16) – 1 record created, 00:00.022
  shouldn't include any extra attributes (./spec/serializers/education_benefits_claim_serializer_spec.rb:21) – 1 record created, 00:00.030
  should include regional_office (./spec/serializers/education_benefits_claim_serializer_spec.rb:16) – 1 record created, 00:00.025

Vet360Redis::ContactInformation (./spec/models/vet360_redis/contact_information_spec.rb:6) (1 record created, 00:00.017)
  returns the users mailing address object (./spec/models/vet360_redis/contact_information_spec.rb:86) – 1 record created, 00:00.017

HealthCareApplication (./spec/models/health_care_application_spec.rb:5) (3 records created, 00:00.087)
  should return nil (./spec/models/health_care_application_spec.rb:69) – 1 record created, 00:00.036
  should return the icn (./spec/models/health_care_application_spec.rb:79) – 1 record created, 00:00.025
  should create a mvi compatible hash of attributes (./spec/models/health_care_application_spec.rb:94) – 1 record created, 00:00.025

PersistentAttachments::PensionBurial (./spec/models/persistent_attachments/pension_burial_spec.rb:5) (1 record created, 00:00.041)
  offsets a user timestamp by their browser data (./spec/models/persistent_attachments/pension_burial_spec.rb:29) – 1 record created, 00:00.041

EducationForm::Forms::VA1990 (./spec/jobs/education_form/forms/va1990_spec.rb:5) (11 records created, 00:00.276)
  adds disclosures for different types (./spec/jobs/education_form/forms/va1990_spec.rb:60) – 1 record created, 00:00.025
  handles chapter 33 relinquishments (./spec/jobs/education_form/forms/va1990_spec.rb:68) – 1 record created, 00:00.024
  shows a partial containing the CH30 disclaimer (./spec/jobs/education_form/forms/va1990_spec.rb:52) – 1 record created, 00:00.024
  shows a partial containing the CH33_30 disclaimer (./spec/jobs/education_form/forms/va1990_spec.rb:52) – 1 record created, 00:00.025
  shows a partial containing the CH33_1607 disclaimer (./spec/jobs/education_form/forms/va1990_spec.rb:52) – 1 record created, 00:00.026
  shows a partial containing the CH1606 disclaimer (./spec/jobs/education_form/forms/va1990_spec.rb:52) – 1 record created, 00:00.025
  shows a partial containing the CH32 disclaimer (./spec/jobs/education_form/forms/va1990_spec.rb:52) – 1 record created, 00:00.023
  shows a partial containing the CH33_1606 disclaimer (./spec/jobs/education_form/forms/va1990_spec.rb:52) – 1 record created, 00:00.025
  shows a partial containing the CH33 disclaimer (./spec/jobs/education_form/forms/va1990_spec.rb:52) – 1 record created, 00:00.026
  includes partial records (./spec/jobs/education_form/forms/va1990_spec.rb:26) – 1 record created, 00:00.025
  always outputs 5 double-spaced lines (./spec/jobs/education_form/forms/va1990_spec.rb:18) – 1 record created, 00:00.024

VIC::ProfilePhotoAttachment (./spec/models/vic/profile_photo_attachment_spec.rb:5) (1 record created, 00:00.011)
  should use the new filename to get the file (./spec/models/vic/profile_photo_attachment_spec.rb:23) – 1 record created, 00:00.011

V0::GIBillFeedbacksController (./spec/controllers/v0/gi_bill_feedbacks_controller_spec.rb:6) (1 record created, 00:00.013)
  should find a gi bill feedback submission by guid (./spec/controllers/v0/gi_bill_feedbacks_controller_spec.rb:42) – 1 record created, 00:00.013

HCA::RateLimitedSearch (./spec/lib/hca/rate_limited_search_spec.rb:5) (2 records created, 00:00.049)
  should combine non-ssn user attributes (./spec/lib/hca/rate_limited_search_spec.rb:9) – 1 record created, 00:00.024
  should create rate limited search models (./spec/lib/hca/rate_limited_search_spec.rb:25) – 1 record created, 00:00.025

Preneeds::BurialForm (./spec/models/preneeds/burial_form_spec.rb:5) (8 records created, 00:00.049)
  compares a form against the schema (./spec/models/preneeds/burial_form_spec.rb:50) – 2 records created, 00:00.016
  converts its attributes from snakecase to camelcase (./spec/models/preneeds/burial_form_spec.rb:43) – 2 records created, 00:00.010
  generates a tracking_number (./spec/models/preneeds/burial_form_spec.rb:11) – 2 records created, 00:00.011
  provides vets.gov as the sending_application (./spec/models/preneeds/burial_form_spec.rb:19) – 2 records created, 00:00.011

EducationForm::CreateDailySpoolFiles (./spec/jobs/education_form/create_daily_spool_files_spec.rb:5) (6 records created, 00:00.142)
  contains only windows-style newlines (./spec/jobs/education_form/create_daily_spool_files_spec.rb:97) – 1 record created, 00:00.022
  outputs a valid spool file fragment (./spec/jobs/education_form/create_daily_spool_files_spec.rb:93) – 1 record created, 00:00.024
  tracks and returns a form object (./spec/jobs/education_form/create_daily_spool_files_spec.rb:73) – 1 record created, 00:00.024
  tracks the 1995 form (./spec/jobs/education_form/create_daily_spool_files_spec.rb:83) – 1 record created, 00:00.020
  should log a message on holidays (./spec/jobs/education_form/create_daily_spool_files_spec.rb:48) – 1 record created, 00:00.025
  is only triggered by sidekiq-scheduler on weekdays (./spec/jobs/education_form/create_daily_spool_files_spec.rb:33) – 1 record created, 00:00.025

Preneeds::Service (./spec/lib/preneeds/service_spec.rb:6) (2 records created, 00:00.010)
  creates a preneeds application (./spec/lib/preneeds/service_spec.rb:124) – 2 records created, 00:00.010

Preneeds Burial Form Integration (./spec/request/preneeds/burial_forms_request_spec.rb:5) (2 records created, 00:00.012)
  returns an with error (./spec/request/preneeds/burial_forms_request_spec.rb:25) – 2 records created, 00:00.012

EVSSClaimServiceAsync (./spec/services/evss_claim_service_async_spec.rb:5) (36 records created, 00:00.183)
  returns the claim (./spec/services/evss_claim_service_async_spec.rb:60) – 4 records created, 00:00.015
  sets status to 'REQUESETED' (./spec/services/evss_claim_service_async_spec.rb:55) – 4 records created, 00:00.016
  creates a background job (./spec/services/evss_claim_service_async_spec.rb:50) – 4 records created, 00:00.017
  returns an array of claims (./spec/services/evss_claim_service_async_spec.rb:71) – 4 records created, 00:00.035
  deletes the existing tracker entry (./spec/services/evss_claim_service_async_spec.rb:75) – 4 records created, 00:00.015
  deletes the existing tracker entry (./spec/services/evss_claim_service_async_spec.rb:75) – 4 records created, 00:00.026
  returns an array of claims (./spec/services/evss_claim_service_async_spec.rb:71) – 4 records created, 00:00.021
  deletes the existing tracker entry (./spec/services/evss_claim_service_async_spec.rb:38) – 4 records created, 00:00.017
  deletes the existing tracker entry (./spec/services/evss_claim_service_async_spec.rb:38) – 4 records created, 00:00.018

EducationForm::Forms::Base (./spec/jobs/education_form/forms/base_spec.rb:5) (16 records created, 00:00.417)
  returns 1990 forms (./spec/jobs/education_form/forms/base_spec.rb:10) – 1 record created, 00:00.025
  should return the benefit type shorthand (./spec/jobs/education_form/forms/base_spec.rb:76) – 2 records created, 00:00.044
  should return the blank string (./spec/jobs/education_form/forms/base_spec.rb:107) – 1 record created, 00:00.024
  should format the address correctly (./spec/jobs/education_form/forms/base_spec.rb:113) – 1 record created, 00:00.023
  should format the address correctly (./spec/jobs/education_form/forms/base_spec.rb:144) – 1 record created, 00:00.026
  should format the address correctly (./spec/jobs/education_form/forms/base_spec.rb:123) – 1 record created, 00:00.027
  should format the address correctly (./spec/jobs/education_form/forms/base_spec.rb:133) – 1 record created, 00:00.030
  should be included (./spec/jobs/education_form/forms/base_spec.rb:92) – 1 record created, 00:00.026
  should not have extra spaces (./spec/jobs/education_form/forms/base_spec.rb:86) – 1 record created, 00:00.028
  should output the hours (./spec/jobs/education_form/forms/base_spec.rb:31) – 1 record created, 00:00.025
  should return blank string (./spec/jobs/education_form/forms/base_spec.rb:50) – 1 record created, 00:00.027
  should output hours and hours_type (./spec/jobs/education_form/forms/base_spec.rb:44) – 1 record created, 00:00.028
  returns N/A for nil values (./spec/jobs/education_form/forms/base_spec.rb:57) – 1 record created, 00:00.024
  returns YES for truthy values (./spec/jobs/education_form/forms/base_spec.rb:63) – 1 record created, 00:00.027
  returns NO for falsey values (./spec/jobs/education_form/forms/base_spec.rb:60) – 1 record created, 00:00.026

V0::DependentsApplicationsController (./spec/controllers/v0/dependents_applications_controller_spec.rb:5) (5 records created, 00:00.043)
  should return a dependents application (./spec/controllers/v0/dependents_applications_controller_spec.rb:19) – 5 records created, 00:00.043

VIC::VICSubmission (./spec/models/vic/vic_submission_spec.rb:5) (6 records created, 00:00.029)
  should be invalid (./spec/models/vic/vic_submission_spec.rb:26) – 3 records created, 00:00.015
  should be valid (./spec/models/vic/vic_submission_spec.rb:20) – 3 records created, 00:00.013

Common::ConvertToPdf (./spec/lib/common/convert_to_pdf_spec.rb:5) (3 records created, 00:00.117)
  converts an image to pdf format (./spec/lib/common/convert_to_pdf_spec.rb:24) – 1 record created, 00:00.032
  should still be pdf and not run convert (./spec/lib/common/convert_to_pdf_spec.rb:39) – 1 record created, 00:00.053
  raise an IOError (./spec/lib/common/convert_to_pdf_spec.rb:30) – 1 record created, 00:00.031

EVSS::DisabilityCompensationForm::SubmitForm526IncreaseOnly (./spec/jobs/evss/disability_compensation_form/submit_form526_increase_only_spec.rb:7) (5 records created, 00:00.027)
  queues a job for submit (./spec/jobs/evss/disability_compensation_form/submit_form526_increase_only_spec.rb:30) – 5 records created, 00:00.027

VIC::Service (./spec/lib/vic/service_spec.rb:5) (12 records created, 00:00.107)
  should submit the form and attached documents (./spec/lib/vic/service_spec.rb:223) – 4 records created, 00:00.028
  should submit the form (./spec/lib/vic/service_spec.rb:230) – 3 records created, 00:00.026
  should convert files to pdf and combine them (./spec/lib/vic/service_spec.rb:108) – 2 records created, 00:00.025
  should format the form (./spec/lib/vic/service_spec.rb:61) – 3 records created, 00:00.027

AsyncTransaction::EVSS::VA526ezSubmitTransaction (./spec/models/async_transaction/evss/va526ez_submit_transaction_spec.rb:5) (7 records created, 00:00.030)
  updates a transaction (./spec/models/async_transaction/evss/va526ez_submit_transaction_spec.rb:117) – 7 records created, 00:00.030

PdfFill::Filler (./spec/lib/pdf_fill/filler_spec.rb:6) (6 records created, 00:00.183)
  should fill the form correctly (./spec/lib/pdf_fill/filler_spec.rb:73) – 1 record created, 00:00.042
  should fill the form correctly (./spec/lib/pdf_fill/filler_spec.rb:73) – 1 record created, 00:00.055
  should fill the form correctly (./spec/lib/pdf_fill/filler_spec.rb:73) – 1 record created, 00:00.025
  should fill the form correctly (./spec/lib/pdf_fill/filler_spec.rb:73) – 1 record created, 00:00.020
  should fill the form correctly (./spec/lib/pdf_fill/filler_spec.rb:73) – 1 record created, 00:00.015
  should fill the form correctly (./spec/lib/pdf_fill/filler_spec.rb:73) – 1 record created, 00:00.023

EVSS::DependentsApplicationJob (./spec/jobs/evss/dependents_application_job_spec.rb:5) (12 records created, 00:00.113)
  submits to the 686 api (./spec/jobs/evss/dependents_application_job_spec.rb:27) – 4 records created, 00:00.040
  uses, then deletes a cache of user info (./spec/jobs/evss/dependents_application_job_spec.rb:42) – 4 records created, 00:00.037
  should set the dependents_application to failed (./spec/jobs/evss/dependents_application_job_spec.rb:15) – 4 records created, 00:00.035

DependentsApplication (./spec/models/dependents_application_spec.rb:5) (2 records created, 00:00.044)
  should merge the evss and submitted forms (./spec/models/dependents_application_spec.rb:32) – 2 records created, 00:00.044

EducationBenefitsClaim (./spec/models/education_benefits_claim_spec.rb:5) (26 records created, 00:00.689)
  should return true when it's the right type (./spec/models/education_benefits_claim_spec.rb:19) – 1 record created, 00:00.045
  should return false when it's not the right type (./spec/models/education_benefits_claim_spec.rb:14) – 1 record created, 00:00.036
  should create a submission (./spec/models/education_benefits_claim_spec.rb:146) – 1 record created, 00:00.021
  should create a submission (./spec/models/education_benefits_claim_spec.rb:179) – 1 record created, 00:00.016
  should create a submission (./spec/models/education_benefits_claim_spec.rb:163) – 1 record created, 00:00.014
  should create a submission (./spec/models/education_benefits_claim_spec.rb:112) – 1 record created, 00:00.016
  should create a submission (./spec/models/education_benefits_claim_spec.rb:129) – 1 record created, 00:00.016
  should return true when it's the right type (./spec/models/education_benefits_claim_spec.rb:19) – 1 record created, 00:00.023
  should return false when it's not the right type (./spec/models/education_benefits_claim_spec.rb:14) – 1 record created, 00:00.024
  should return the regional office (./spec/models/education_benefits_claim_spec.rb:33) – 1 record created, 00:00.023
  should return true when it's the right type (./spec/models/education_benefits_claim_spec.rb:19) – 1 record created, 00:00.022
  should return false when it's not the right type (./spec/models/education_benefits_claim_spec.rb:14) – 1 record created, 00:00.022
  shouldnt copy fields from previous benefits (./spec/models/education_benefits_claim_spec.rb:221) – 1 record created, 00:00.024
  should copy fields from previous benefits (./spec/models/education_benefits_claim_spec.rb:233) – 1 record created, 00:00.024
  should return the form type (./spec/models/education_benefits_claim_spec.rb:27) – 1 record created, 00:00.023
  raises an error if an invalid region is entered (./spec/models/education_benefits_claim_spec.rb:242) – 1 record created, 00:00.022
  should return false when it's not the right type (./spec/models/education_benefits_claim_spec.rb:14) – 1 record created, 00:00.022
  should return true when it's the right type (./spec/models/education_benefits_claim_spec.rb:19) – 1 record created, 00:00.023
  should return false when it's not the right type (./spec/models/education_benefits_claim_spec.rb:14) – 1 record created, 00:00.025
  should return true when it's the right type (./spec/models/education_benefits_claim_spec.rb:19) – 1 record created, 00:00.038
  should return true when it's the right type (./spec/models/education_benefits_claim_spec.rb:19) – 1 record created, 00:00.036
  should return false when it's not the right type (./spec/models/education_benefits_claim_spec.rb:14) – 1 record created, 00:00.026
  should return false when it's not the right type (./spec/models/education_benefits_claim_spec.rb:14) – 1 record created, 00:00.032
  should return true when it's the right type (./spec/models/education_benefits_claim_spec.rb:19) – 1 record created, 00:00.051
  should return false when it's not the right type (./spec/models/education_benefits_claim_spec.rb:14) – 1 record created, 00:00.030
  should return true when it's the right type (./spec/models/education_benefits_claim_spec.rb:19) – 1 record created, 00:00.026

User (./spec/models/user_spec.rb:5) (4 records created, 00:00.012)
  first attempts to fetch the Account record from the Redis cache (./spec/models/user_spec.rb:466) – 4 records created, 00:00.012

Users::Profile (./spec/services/users/profile_spec.rb:5) (9 records created, 00:00.089)
  sets #scaffold.status to 200 (./spec/services/users/profile_spec.rb:12) – 3 records created, 00:00.013
  sets #scaffold.errors to an empty array (./spec/services/users/profile_spec.rb:16) – 3 records created, 00:00.048
  raises an exception (./spec/services/users/profile_spec.rb:21) – 3 records created, 00:00.027

Vet360::Person::Service (./spec/lib/vet360/person/service_spec.rb:5) (1 record created, 00:00.010)
  returns a status of 200 (./spec/lib/vet360/person/service_spec.rb:14) – 1 record created, 00:00.010

VIC::AttachmentUploadJob (./spec/jobs/vic/attachment_upload_job_spec.rb:5) (3 records created, 00:00.030)
  should call send_files (./spec/jobs/vic/attachment_upload_job_spec.rb:7) – 3 records created, 00:00.030

Disability compensation form (./spec/request/disability_compensation_form_request_spec.rb:5) (4 records created, 00:00.015)
  returns a 500 when name_part is missing (./spec/request/disability_compensation_form_request_spec.rb:89) – 4 records created, 00:00.015

UserPreferences::Validator (./spec/services/user_preferences/validator_spec.rb:5) (37 records created, 00:00.119)
  raises an exception (./spec/services/user_preferences/validator_spec.rb:198) – 5 records created, 00:00.014
  raises an exception (./spec/services/user_preferences/validator_spec.rb:167) – 4 records created, 00:00.012
  does not raise any exceptions (./spec/services/user_preferences/validator_spec.rb:40) – 6 records created, 00:00.020
  returns the original initialized requested_user_preferences (./spec/services/user_preferences/validator_spec.rb:44) – 6 records created, 00:00.022
  raises an exception (./spec/services/user_preferences/validator_spec.rb:136) – 4 records created, 00:00.012
  raises an exception (./spec/services/user_preferences/validator_spec.rb:72) – 6 records created, 00:00.018
  raises an exception (./spec/services/user_preferences/validator_spec.rb:106) – 6 records created, 00:00.018

VIC::SupportingDocumentationAttachment (./spec/models/vic/supporting_documentation_attachment_spec.rb:5) (1 record created, 00:00.012)
  should use the new filename to get the file (./spec/models/vic/supporting_documentation_attachment_spec.rb:11) – 1 record created, 00:00.012

EducationForm::Forms::VA5490 (./spec/jobs/education_form/forms/va5490_spec.rb:5) (3 records created, 00:00.052)
  previously_applied_for_benefits? should return false (./spec/jobs/education_form/forms/va5490_spec.rb:37) – 1 record created, 00:00.017
  previous_benefits should return the right value (./spec/jobs/education_form/forms/va5490_spec.rb:59) – 1 record created, 00:00.017
  previously_applied_for_benefits? should return true (./spec/jobs/education_form/forms/va5490_spec.rb:65) – 1 record created, 00:00.018

SavedClaim (./spec/models/saved_claim_spec.rb:5) (1 record created, 00:00.021)
  should convert form to pdf (./spec/models/saved_claim_spec.rb:9) – 1 record created, 00:00.021

VA GIS Integration (./spec/request/va_facilities_request_spec.rb:5) (48 records created, 00:00.237)
  should eq "\"[\"foo\", \"health\"]\" is not a valid value for \"type\"" (./spec/request/va_facilities_request_spec.rb:298) – 12 records created, 00:00.054
  should eq "The required parameter \"name_part\", is missing" (./spec/request/va_facilities_request_spec.rb:314) – 12 records created, 00:00.056
  should eq "The required parameter \"type\", is missing" (./spec/request/va_facilities_request_spec.rb:306) – 12 records created, 00:00.059
  should eq "\"[\"foo\"]\" is not a valid value for \"type\"" (./spec/request/va_facilities_request_spec.rb:290) – 12 records created, 00:00.067

V0::SessionsController (./spec/controllers/v0/sessions_controller_spec.rb:7) (5 records created, 00:00.010)
  uplevels an LOA 1 session to LOA 3 (./spec/controllers/v0/sessions_controller_spec.rb:327) – 5 records created, 00:00.010

V0::PreferencesController (./spec/controllers/v0/preferences_controller_spec.rb:5) (20 records created, 00:00.070)
  returns unauthorized (./spec/controllers/v0/preferences_controller_spec.rb:13) – 4 records created, 00:00.012
  returns unauthorized (./spec/controllers/v0/preferences_controller_spec.rb:58) – 16 records created, 00:00.057

EVSS::DisabilityCompensationForm::SubmitForm8940 (./spec/jobs/evss/disability_compensation_form/submit_form8940_spec.rb:7) (5 records created, 00:00.032)
  queues a job for submit (./spec/jobs/evss/disability_compensation_form/submit_form8940_spec.rb:43) – 5 records created, 00:00.032

EVSS::UpdateClaimFromRemoteJob (./spec/jobs/evss/update_claim_from_remote_job_spec.rb:5) (4 records created, 00:00.028)
  should set the status to FAILED (./spec/jobs/evss/update_claim_from_remote_job_spec.rb:53) – 4 records created, 00:00.028

EVSS::DisabilityCompensationForm::DataTranslation (./spec/lib/evss/disability_compensation_form/data_translation_spec.rb:6) (2 records created, 00:00.072)
  should translate the fields correctly (./spec/lib/evss/disability_compensation_form/data_translation_spec.rb:237) – 1 record created, 00:00.012
  should return "INTERNATIONAL" (./spec/lib/evss/disability_compensation_form/data_translation_spec.rb:53) – 1 record created, 00:00.060

SAML::URLService (./spec/lib/saml/url_service_spec.rb:7) (1 record created, 00:00.019)
  has a logout redirect url (./spec/lib/saml/url_service_spec.rb:200) – 1 record created, 00:00.019

the API documentation (./spec/request/swagger_spec.rb:23) (46 records created, 00:00.204)
  returns a 429 with error details (./spec/request/swagger_spec.rb:62) – 2 records created, 00:00.010
  supports getting rated disabilities (./spec/request/swagger_spec.rb:402) – 3 records created, 00:00.012
  supports updating payment information (./spec/request/swagger_spec.rb:531) – 2 records created, 00:00.011
  supports folder error messages (./spec/request/swagger_spec.rb:639) – 2 records created, 00:00.011
  supports getting a message (./spec/request/swagger_spec.rb:673) – 2 records created, 00:00.011
  supports moving a message to another folder (./spec/request/swagger_spec.rb:693) – 2 records created, 00:00.010
  supports error message with invalid id (./spec/request/swagger_spec.rb:773) – 2 records created, 00:00.010
  supports retrieving eligible data classes (./spec/request/swagger_spec.rb:970) – 2 records created, 00:00.014
  supports posting EVSS Letters (./spec/request/swagger_spec.rb:1088) – 2 records created, 00:00.010
  supports putting EVSS PCIUAddress (./spec/request/swagger_spec.rb:1113) – 2 records created, 00:00.010
  validates auth errors (./spec/request/swagger_spec.rb:1195) – 5 records created, 00:00.022
  400s on invalid type (./spec/request/swagger_spec.rb:1271) – 3 records created, 00:00.013
  supports getting email address data (./spec/request/swagger_spec.rb:1528) – 2 records created, 00:00.010
  supports getting primary phone number data (./spec/request/swagger_spec.rb:1535) – 2 records created, 00:00.012
  supports getting connected applications (./spec/request/swagger_spec.rb:1888) – 5 records created, 00:00.012
  supports removing connected applications grants (./spec/request/swagger_spec.rb:1897) – 5 records created, 00:00.011
  supports returning a custom 403 Forbidden response (./spec/request/swagger_spec.rb:1919) – 3 records created, 00:00.010

MHVLoggingService (./spec/services/mhv_logging_service_spec.rb:6) (3 records created, 00:00.011)
  does not logout when not logged in (./spec/services/mhv_logging_service_spec.rb:41) – 3 records created, 00:00.011
kreek commented 5 years ago

Two PRs reference this ticket: https://github.com/department-of-veterans-affairs/vets-api/pull/3170 https://github.com/department-of-veterans-affairs/vets-api/pull/3169

PR # 3169 is in a draft mode as it requires more work than could fit in one sprint as outlined in this ticket.