Decide on technical approach for MHV account dependency in API integrations

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:

https://depo-platform-documentation.scrollhelp.site/index.html

281 stars 197 forks source link

Decide on technical approach for MHV account dependency in API integrations #37322

Open patrickvinograd opened 2 years ago

patrickvinograd commented 2 years ago

Initial writeup here: https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/products/health-care/digital-health-modernization/engineering/mhv-account-options.md

patrickvinograd commented 2 years ago

Historical PRs: Removing account creation/upgrade from frontend: https://github.com/department-of-veterans-affairs/vets-website/pull/12624

Adding MHV account state to user profile from backend: https://github.com/department-of-veterans-affairs/vets-api/pull/4299

patrickvinograd commented 2 years ago

Conversation with Barry from MHV team on 2/23/2022:

MHV account creation API is believed to still work, no reason to expect otherwise - Barry thought we were still using it; the above PRs indicate otherwise
Opportunity to refresh and make them more robust
Avoid the approach for deriving account tier from blue button data elements, make a proper API.
Review sequestered accounts for any loopholes (esp. cross-credential loopholes), otherwise there's not any major implementation complexity with them.
The intent is to do away with all account tiers other than premium.
If true, then maybe determining account type is less critical (since there's only one) - but we may have an interval where there are legacy lower-tier accounts.
If true, ideally collapse account creation+upgrade into one operation, since there's no reason to create un-upgraded accounts.

Terminology for formerly "advanced" accounts is "basic matched".

MarciMcGuire commented 1 year ago

Eric, is this issues still needed? Thanks!

ericvoshall commented 1 year ago

@MarciMcGuire Yeah.

dcloud commented 1 year ago

I put a large estimate on this due to my uncertainty, but some aspects may also become a lot clearer as part of the research into preferences, #54197.

A good starting place will be reconnecting with Barry about the topics Patrick noted in Feb 2022.

MarciMcGuire commented 1 year ago

Makes sense. Thank you!

MarciMcGuire commented 1 year ago

@dcloud just checking to see if this needs to move to the next sprint or if I should put it into the backlog for now.

dcloud commented 1 year ago

I think it can go into the backlog for now, though this might be a good issue (plus linked items) for our new architect to read over.

carlosfelix2 commented 1 year ago

The document linked has some great information about the MVH login process. I would make that required reading!!!