department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

Accessibility Feedback - Midpoint Review - Identity, Inherited Proofing #38525

Open briandeconinck opened 2 years ago

briandeconinck commented 2 years ago

VFS acceptance criteria

Thoughts/questions

Feedback

Must: Make sure you maintain material honesty and choose buttons and links carefully. The key thing here is:

For example, looking at the CTA buttons for Login.gov and ID.me:

Call to Action for account creation, with a red Login.gov button, a green ID.me button, and a transparent dismiss button.

Since these are static prototypes I can't know for sure, but these feel navigational to me---like they're going to take me to an account creation page (like the "Create a Login.gov account" action link at the end of the wizard), rather than triggering an action on this page.

Should:

Call to Action for account creation, with a red Login.gov button, a green ID.me button, and a transparent dismiss button.

Consider: For the CTA buttons for Login.gov and ID.me (if they end up being buttons): Red and green buttons right next to each other raises concerns for color blind users. Since color is only being used to match third-party branding and isn't being used to convey additional information, it's not something I would label as a must-change. But if there's a design option that's not a red button / green button side-by-side I think it would give accessibility folks less heartburn! (cc @artsymartha68, who flagged this after the meeting today.)

Platform directions

briandeconinck commented 2 years ago

Added some additional "should" items after a follow-up conversation with folks on the Governance team. It will likely overlap some with what you hear from design, IA, and sitewide content.

artsymartha68 commented 2 years ago

Thanks, @briandeconinck. After I was able to zoom in I realized that yes these red and green buttons are branded with the colors for Login and ID.me as per the login screen designs from Ryan. I don't like the way they look on a light blue background, that's a visual design opinion/judgment.