department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

AWS Staging: Type of Care not Displayed on a Booked CC Appointment Detail Page #41390

Closed aarathi-poldass closed 2 years ago

aarathi-poldass commented 2 years ago

What happened?

When an CC appointment is scheduled trough HSRM. Under the Upcoming queue the CC booked/ upcoming appointment is missing the type of care attribute on the Detail page.

Specs:

Steps to Reproduce

VAOS:

Expected Results: When looking at the detail card of a CC booked/upcoming appt the Type of care should be displayed

Actual Results: Type of Care is missing from the detail card on a CC upcoming appointment image

aarathi-poldass commented 2 years ago

@ldelacosta - I don't have permissions to add labels - project and assignees, can you please add them for me. Also, can you please prioritize this ticket. Thank you.

ldelacosta commented 2 years ago

@aarathi-poldass - We have reviewed this ticket and will address it in #41390 (V0 does not have type of care available and V2 has it available). I will let you know when the work is done so you can test. Thanks!

ldelacosta commented 2 years ago

Waiting for #41492 to be completed.

ldelacosta commented 2 years ago

@aarathi-poldass - This can be tested and let us know if you experience any issues. Thanks.

ldelacosta commented 2 years ago

Tried to submit a CC request, getting an error. Per Marcy's comment, This is a known bug. HSRM for some reason is taking + 30 secs to reply and the call is getting timed out. Thomas will be reaching out to HSRM to work on the VAOSR-3700 ticket.

marcynadeau commented 2 years ago

This is currently blocked by VAOSR-3700. https://issues.mobilehealth.va.gov/browse/VAOSR-3700. STAGING: Encountering 504 error while creating CC request

aarathi-poldass commented 2 years ago

Validation Failed - Type of Care is still missing from the detail card on a CC upcoming appointment. Please find attached a screenshot for reference. @ldelacosta

image

ldelacosta commented 2 years ago

Moving this ticket back to Blocked since #41492 ticket is back in development for further review.

ldelacosta commented 2 years ago

@aarathi-poldass - This has been addressed. Please proceed with testing. Thanks!

marcynadeau commented 2 years ago

@ldelacosta I did a quick smoke test while I was in testing something else and this looks like it is fixed. Aarathi has more detailed testing to complete the defect but I thought I would let you know in my smoke test this is working.

ldelacosta commented 2 years ago

Moving this ticket back to Blocked. Found an issue and team will address it.

ldelacosta commented 2 years ago

@aarathi-poldass - This is ready to be tested. Please let us know if you are still having issues. Thanks!

aarathi-poldass commented 2 years ago

Re-tested the defect and failed validation. When a request is made through VAOS and booked using HSRM the "Type of care" is missing on the Upcoming appointment detail page. This issues was discussed on the BR scrum call and upon analysis the SQA team was suggested to run a Test using VAOS test harness and compare the results/ response. The test were run and in both scenarios the "Type of Care" is not being displayed in VAOS UI. Please find the screenshot below for reference.

image.png

Note: The Response data was sent to Leah over slack. @ldelacosta - Can you please assign this ticket back to the developer for further analysis.

ldelacosta commented 2 years ago

We added the type of care label for booked CC appointments.

Screen Shot 2022-06-27 at 3.02.00 PM.png

Per review, the serviceType is not available when the status is booked In the event that the data is available in the response body, the UI will display the type of care label for the CC appointments.

We have a ticket #43460 to add a logic if the type of care data is not available, we will suppress the label on the frontend.

cc: @aarathi-poldass

ldelacosta commented 2 years ago

@aarathi-poldass If you're good with this ticket, please close it out. As per my comment, we added the type of care but cannot be validated with data since HSRM is not sending back serviceType. In the event it does, FE will display the data and label on the appointment details page.

cc: @simiadebowale

marcynadeau commented 2 years ago

Waiting on linked ticket to be fixed before we can test this one. https://github.com/department-of-veterans-affairs/va.gov-team/issues/43460

aarathi-poldass commented 2 years ago

Reviewed on 7.21.22 with PM and project leads and this issue was given a High priority

ldelacosta commented 2 years ago

@aarathi-poldass - This is ready to be tested since #43460 is completed.

aarathi-poldass commented 2 years ago

Re-tested the defect with 2 scenarios. Please find below the detailed discerption:

Scenario 1: When HSRM doesn't return the Type of Care field in the response body for a booked appointment, VAOS is not displaying the type of care on FE. Response body: { "id": "117292", "type": "appointments", "attributes": { "id": "117292", "identifier": [ { "system": "http://med.va.gov/fhir/urn/vaos/hsrm/id", "value": "524621||6||1" } ], "kind": "cc", "status": "booked", "patientIcn": "1013120830V747912", "locationId": "984", "start": "2022-07-23T13:30:00Z", "created": "2022-07-22T13:40:57Z", "cancellable": true, "extension": { "ccLocation": { "address": { "line": [ "10640 MAIN ST ; STE 100" ], "city": "FAIRFAX", "state": "VA", "postalCode": "22030", "text": "10640 MAIN ST ; STE 100\nFAIRFAX VA 22030" }, "telecom": [] }, "hsrmTaskId": "" }, "location": { "id": "984", "type": "appointments", "attributes": { "id": "984", "vistaSite": "984", "vastParent": "984", "type": "va_health_facility", "name": "Dayton VA Medical Center", "classification": "VA Medical Center (VAMC)", "timezone": { "timeZoneId": "America/New_York" }, "lat": 39.74935, "long": -84.2532, "website": "https://www.dayton.va.gov/locations/directions.asp", "phone": { "main": "937-268-6511" }, "physicalAddress": { "type": "physical", "line": [ "4100 West Third Street" ], "city": "Dayton", "state": "OH", "postalCode": "45428-9000" }, "healthService": [ "Audiology", "Cardiology", "DentalServices", "Dermatology", "Gastroenterology", "Gynecology", "MentalHealthCare", "Nutrition", "Ophthalmology", "Optometry", "Orthopedics", "Podiatry", "PrimaryCare", "SpecialtyCare", "Urology", "WomensHealth" ] } } } image.png

Scenario 2: When HSRM returns the Type of Care field in the response body for a booked appointment. I tried multiple instance and HSRM is not returning the type of care, so I reached out to Kent and Moshe to see if we can send that field in the response so that I can validate it on the VAOS side. I'm still awaiting their response.

aarathi-poldass commented 2 years ago

As per the discussion with Grace and Marcy the system is working as expected. @ldelacosta as this passed validation please go ahead and close the ticket. Thank you!

ldelacosta commented 2 years ago

No issues reported. Closing out the ticket.