department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 202 forks source link

[Spike] Identify which college score card columns are used by the api when selecting the correct color of cards. #42295

Closed MitchLivingstone closed 2 years ago

MitchLivingstone commented 2 years ago

Issue Description

Provide a sample list to Brian/EDU for them to verify whether the columns used and the color on the cards are correct.

It will be determined when a specific school is selected, the color will reflect the correct color.

AdamFreemer commented 2 years ago

Can EDU detail examples of color coded cards that have irregularities, or are not rendering with the correct color according to EDU requirements, so we can confirm code is working correctly.

MitchLivingstone commented 2 years ago

Updated title to reflect "college score card columns". 06/13/2022

AdamFreemer commented 2 years ago

FYI, if it's helpful, these are the coded Institution Card header color schemes:

Screen Shot 2022-06-13 at 1.44.21 PM.png

MitchLivingstone commented 2 years ago

.employer-header is labeled as - "On-the-job training and apprenticeships" " in the Calculate my benefits page"

AdamFreemer commented 2 years ago

The Institution spreadsheet has no identifiable column for type (school, employer, vettec) from what I can tell. If Brian can detail on the VA side the documented definitions for what identifies an Institution to be a School, Employer or Vettec, in the data he uploads, we can confirm any irregularities he may be experiencing on the development side.

AdamFreemer commented 2 years ago

SQL for updating the 3 boolean fields. school, employer or vettec. When 1 is true and other is false, institution is labeled as indicated type true (with corresponding color on front end).

school_provider = CASE WHEN institution_type_name IN (:schools) AND vet_tec_provider IS FALSE THEN TRUE ELSE FALSE END,
employer_provider = CASE WHEN institution_type_name = :employer AND vet_tec_provider IS FALSE THEN TRUE ELSE FALSE END

UPDATE institutions SET vet_tec_provider = TRUE
  from versions
  WHERE substring(institutions.facility_code, 2 , 1) = 'V'
   AND institutions.version_id = #{version_id}
SQL
MitchLivingstone commented 2 years ago

@AdamFreemer Please see tab under "Scorecard" and identify the fourteen items with a "Yes or No" if it's being used by the Scorecard.

https://app.zenhub.com/files/133843125/faf3849c-44cb-447e-a088-610ccd5100bc/download

AdamFreemer commented 2 years ago

Livingstone, Mitch [GRAY DIGITAL LLC] - I was looking through fields, then realized on this card, it looks like we went from "is this field displayed on card" to "if it's being used by the Scorecard". Honestly I don't know what that means. Scorecard can mean several things, the file imported, scorecard data / api, is that a reference to a "card" (we display institutions as cards), etc. The answer is different for each of the above.

Also, there is different data on the Institution profile page, search result card, and also data not shown on either (alias information, which is what autocomplete uses). I guess we need clarification here to continue.

AdamFreemer commented 2 years ago

As discussed, specifically on the Institution Search card result, and the corresponding Institution Details page, please see below. Two example pages given for clarity that specifically correspond to below data: https://staging.va.gov/education/gi-bill-comparison-tool/?search=name&name=harvard https://staging.va.gov/education/gi-bill-comparison-tool/institution/31800121 Screen Shot 2022-07-15 at 3.07.04 PM.png

AdamFreemer commented 2 years ago

[https://app.zenhub.com/files/133843125/7faec013-2fea-444b-bbd8-28f3e2306279/download]

MitchLivingstone commented 2 years ago

Brian received the updated information and is satisfied with the results. The story is completed and closed. 07/18/2022