department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
278 stars 194 forks source link

Burials redirects for parity and rewriting #4645

Closed AnneHurley closed 4 years ago

AnneHurley commented 4 years ago

Instructions

Description

This ticket represents all the Parity and Rewriting legacy redirects for the Burials hub on VA.gov. A list of all the old URLs, and where they are redirecting, with a few we aren't moving for now, is attached.

Requestor Info

Public Websites/Anne Hurley managing project for Burials and Cemetery SMEs.

Implementation Date

1/17/20 (Date communicated to stakeholders)

Please indicate when the redirect(s) needs to be implemented"

The requesting team is responsible for notifying the group working on this issue if the target date changes

Redirects Needed

Current URL | Redirect to new URL

Burials redirects list v2-ah.docx

Steps to complete

mnorthuis commented 4 years ago

These redirects are vetted and ready to go when your team is ready to implement.

Karak888 commented 4 years ago

@kelsonic please have these url's redirected and respond back when you have verified them in Prod? Thanks!

kelsonic commented 4 years ago

To confirm, I'll be implementing these redirects:

Current URL Redirect to new URL
www.cem.va.gov/cem/burial_benefits/eligible.asp www.va.gov/burials-memorials/eligibility/
www.cem.va.gov/cem/Women_and_Minority_Veterans.asp www.va.gov/burials-memorials/eligibility/
www.cem.va.gov/cem/burial_benefits/burial_at_sea.asp www.va.gov/burials-memorials/eligibility/burial-at-sea/
www.cem.va.gov/cem/burial_benefits/private_cemetery.asp www.va.gov/burials-memorials/eligibility/burial-in-private-cemetery/
www.cem.va.gov/cem/burial_benefits/burial_flags.asp www.va.gov/burials-memorials/memorial-items/burial-flags/
www.cem.va.gov/cem/hmm/index.asp www.va.gov/burials-memorials/memorial-items/headstones-markers-medallions/
www.cem.va.gov/cem/hmm/eligibility.asp www.va.gov/burials-memorials/memorial-items/headstones-markers-medallions/
www.cem.va.gov/cem/hmm/order_instructions.asp www.va.gov/burials-memorials/memorial-items/headstones-markers-medallions/
www.cem.va.gov/cem/hmm/apply_by_fax.asp www.va.gov/burials-memorials/memorial-items/headstones-markers-medallions/
www.cem.va.gov/cem/hmm/order_by_mail.asp www.va.gov/burials-memorials/memorial-items/headstones-markers-medallions/
www.cem.va.gov/cem/pmc.asp www.va.gov/burials-memorials/memorial-items/presidential-memorial-certificates/
www.cem.va.gov/cem/pre-need/index.asp www.va.gov/burials-memorials/pre-need-eligibility/
www.cem.va.gov/CEM/pre-need/FAQ/ www.va.gov/burials-memorials/pre-need-eligibility/
www.cem.va.gov/cem/burial_benefits/committal_service.asp www.va.gov/burials-memorials/what-to-expect-at-military-funeral/
https://www.cem.va.gov/cem/hmm/replacements.asp www.va.gov/burials-memorials/memorial-items/headstones-markers-medallions/

And not these redirects:

Current URL Redirect to new URL
https://www.cem.va.gov/cem/hmm/types.asp /burials-memorials/memorial-items/headstones-markers-medallions/types-inscriptions-emblems/
https://www.cem.va.gov/cem/hmm/pre_WWI_era.asp /burials-memorials/memorial-items/headstones-markers-medallions/types-inscriptions-emblems/
https://www.cem.va.gov/cem/hmm/abbreviations.asp /burials-memorials/memorial-items/headstones-markers-medallions/types-inscriptions-emblems/
https://www.cem.va.gov/cem/hmm/emblems.asp /burials-memorials/memorial-items/headstones-markers-medallions/types-inscriptions-emblems/
https://www.cem.va.gov/cems/listcem.asp /burials-memorials/find-a-cemetery/

Does that sound right? šŸ™‚

mnorthuis commented 4 years ago

That is correct to me. Will let @AnneHurley to confirm as well.

AnneHurley commented 4 years ago

@kelsonic @mnorthuis - yes that looks great.

And no rush but can one of you show me how you created that grid in the comment field so I can do that next time? I tried a few times but they ended up wonky.

kelsonic commented 4 years ago

Perfect! @AnneHurley Of course! I'll reach out to you via slack and show you real quick šŸ™‚

Karak888 commented 4 years ago

Thank you! @kelsonic are you able to implement redirects for this?

AnneHurley commented 4 years ago

Thanks everyone!

kelsonic commented 4 years ago

I have a PR open for it šŸ‘https://github.com/department-of-veterans-affairs/vets-website/pull/11436 Just need to validate with @ncksllvn that this is the right place to add those redirects in the code since this is the first time I'm adding cem.va.gov redirects!

kelsonic commented 4 years ago

@AnneHurley Could you validate to see if these redirects are live and as you're expecting? šŸ™‚

lunascoop commented 4 years ago

Stakeholder comm has been sent. Redirect go-live date is 01/17.

lunascoop commented 4 years ago

Posting Slack thread for how to handle URL redirect below (screenshot)

@RLHecht please see Mikki's last comment.

Kelson Adams 6 days ago @Anne Hurley @Selina Cooper @Mikki Need some help figuring out what we need to do with a specific redirect:

image (2)

Kelson Adams 6 days ago I currently have a follow-up PR ready to go with all of the redirects except the one mentioned above https://github.com/department-of-veterans-affairs/vets-website/pull/11459

Kelson Adams 6 days ago Should I leave the /cem/burial_benefits/need.asp redirect for now until we can get more context? :slightly_smiling_face:

Selina Cooper 6 days ago I think so. You have until the 17th.

Kelson Adams 6 days ago Sounds good! Please reach out when we know the steps to implementing the last redirect and I'll send up a PR for it :slightly_smiling_face:

Anne Hurley 6 days ago Thank you both so much!

Kelson Adams 6 days ago Of course! Always happy to help!

Kara Kemahli 6 days ago yes thanks all! Certainly don't want to rush anything! :+1: 1

Mikki Northuis 3 days ago This one will take some coordination since it will include a redirect within drupal for an existing page and then a redirect for the legacy page...similar to the DIC page we did last month. @RLHecht may have some insight on coordinating that. I believe we will need to change the drupal page and implement that redirect first, then you can redirect the legacy page.

RLHecht commented 4 years ago

@lunascoop I can change that URL now if you want. So instead of /plan-a-burial it should be /schedule-a-burial? Let me know if I should go ahead.

ncksllvn commented 4 years ago

Okay, so -

  1. We need to move va.gov/burials-memorials/plan-a-burial/ to va.gov/burials-memorials/schedule-a-burial/ via Drupal
  2. Then, we need a server-side redirect from va.gov/burials-memorials/plan-a-burial/ to va.gov/burials-memorials/schedule-a-burial/
  3. Tomorrow, we need a client-side redirect from cem.va.gov/cem/burial_benefits/need.asp to va.gov/burials-memorials/schedule-a-burial/
lunascoop commented 4 years ago

@mnorthuis can you confirm where the URL should redirect to? It seems it may be /plan-a-burial instead of /schedule-a-burial.

image (2)

@RLHecht Once Mikki confirms the correct redirect URL, you can move it in Drupal.

mnorthuis commented 4 years ago

There is one more item for the steps/list above @ncksllvn - there is an old vets.gov URL that is currently redirected to the /plan-a-burial/ page, so that redirect should be updated as step 4.

In summary, these URLs: https://www.va.gov/burials-memorials/plan-a-burial/ https://www.vets.gov/burials-and-memorials/burial-planning/ https://www.cem.va.gov/cem/burial_benefits/need.asp

Should be redirected to: https://www.va.gov/burials-memorials/schedule-a-burial/

  1. We need to move va.gov/burials-memorials/plan-a-burial/ to va.gov/burials-memorials/schedule-a-burial/ via Drupal AND ensure all nav options updated.
  2. Then, we need a server-side redirect from va.gov/burials-memorials/plan-a-burial/ to va.gov/burials-memorials/schedule-a-burial/
  3. Tomorrow, we need a client-side redirect from cem.va.gov/cem/burial_benefits/need.asp to va.gov/burials-memorials/schedule-a-burial/
  4. Update current server-side redirect of https://www.vets.gov/burials-and-memorials/burial-planning/ to va.gov/burials-memorials/schedule-a-burial/
RLHecht commented 4 years ago

@nick and @Mikki All the Drupal work for the Plan a Burial/Schedule a Burial redirects should be done now. I changed the URL of the page, fixed the name in the top nav as well as the left nav and made sure that on other pages the link points to the node ID so it will update automatically. Let me know if there's anything else I need to do before redirects are in place.

ncksllvn commented 4 years ago

All of these things are done! And it only took me all day. @RLHecht please confirm and close šŸ˜„

ncksllvn commented 4 years ago

There are three broken redirects -

  1. www.cem.va.gov/cem/burial_benefits/eligible.asp,
  2. www.cem.va.gov/cem/burial_benefits/burial_at_sea.asp
  3. www.cem.va.gov/cem/burial_benefits/private_cemetery.asp

The first was a tech issue and am fixing now. The bottom two redirect to the page as specified in the spreadsheet. However the destination does not exist. The destination listed is https://www.va.gov/burials-memorials/eligibility/burial-at-sea/, a 404. What's the correct destination?

RLHecht commented 4 years ago

@ncksllvn This link is should have an "and" between burials-memorials: https://www.va.gov/burials-and-memorials/eligibility/burial-at-sea/

lunascoop commented 4 years ago

@mnorthuis are these the correct URLs? I know there may be another issue with the first one mapping to "burials-and-memorials."

Current URL Redirect to new URL
www.cem.va.gov/cem/burial_benefits/burial_at_sea.asp www.va.gov/burials-and-memorials/eligibility/burial-at-sea/
www.cem.va.gov/cem/burial_benefits/private_cemetery.asp https://www.va.gov/burials-and-memorials/eligibility/burial-in-a-private-cemetery/
ncksllvn commented 4 years ago

Per @mnorthuis, the redirects are okay, but the live URLs aren't correct. So then, in Drupal, we need to move these pages -

www.va.gov/burials-and-memorials/eligibility/burial-at-sea/ -> www.va.gov/burials-memorials/eligibility/burial-at-sea/

www.va.gov/burials-and-memorials/eligibility/burial-in-a-private-cemetery/ -> www.va.gov/burials-memorials/eligibility/burial-in-private-cemetery/

Karak888 commented 4 years ago

@ncksllvn this is the part of the process that you would like to see added in per comment on DSVA correct?

ncksllvn commented 4 years ago

There were a lot of surprises in this ticket. I think we really just need to scope these well during grooming and not do anything with them unless they have been groomed.

ncksllvn commented 4 years ago

@RLHecht when you're back, it would be awesome if you can move those pages.

RLHecht commented 4 years ago

@ncksllvn Those page URLsS have now been fixed in Drupal.

ncksllvn commented 4 years ago

Thanks @RLHecht! I fixed the first broken redirect yesterday. Assuming today's deployment goes out, then this ticket should be all done.

lunascoop commented 4 years ago

Hi @RLHecht Can you update this drupal page: www.va.gov/burials-and-memorials/eligibility/burial-in-a-private-cemetery/ to -> www.va.gov/burials-memorials/eligibility/burial-in-private-cemetery/

Basically, delete the "a"

RLHecht commented 4 years ago

@lunascoop This has been fixed in Drupal.

lunascoop commented 4 years ago

Redirect for URL www.cem.va.gov/cem/burial_benefits/private_cemetery.asp has been implemented. Closing ticket and updating stakeholders.