department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

[Components and pattern standards] Design components or patterns don't align with Design System guidelines. (04.07.2) #46536

Open shiragoodman opened 2 years ago

shiragoodman commented 2 years ago

General Information

VFS team name

Authenticated Experience

VFS product name

My VA

VFS feature name

On-site Notifications

Point of Contact/Reviewers

Allison Christman (@allison0034) - Design

*For more information on how to interpret this ticket, please refer to the Anatomy of a Staging Review issue ticket guidance on Platform Website.


Platform Issue

Design components or patterns don't align with Design System guidelines.

Issue Details

Alert does not contain heading

Link, screenshot or steps to recreate

VA.gov Experience Standard

Category Number 04, Issue Number 07

Other References

WCAG SC 3.2.4 AA


Platform Recommendation

Add a heading to the alert. See Alert headings

VFS Team Tasks to Complete

ajakabcin commented 1 year ago

Angela's design is under review with the design system after which this ticket would be a moot point: https://github.com/department-of-veterans-affairs/vets-design-system-documentation/issues/1181