department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 201 forks source link

Auth Exp Profile | FE | Bug: zoom with gesture disabled for modals on iOS #48006

Closed andaleliz closed 1 year ago

andaleliz commented 1 year ago

In a recent research session, we noticed users can't use a touch gesture to enlarge text in modals. This can be reproduced by:

  1. logging into staging.va.gov (or prod, va.gov), on a touch screen device
  2. going to the Contact Information section of profile.
  3. Click edit on a section
  4. Click edit on another section to trigger the "you are currently editing" modal. Try to use two fingers to zoom in. No dice.

The crisis line modal does allow zoom by touch gesture; the sign in modal does not.

Tasks

AC

andaleliz commented 1 year ago

@SKasimow creating this from the research synthesis while I'm thinking about it. Please assign to FE as you see fit :)

SKasimow commented 1 year ago

FYI...you can zoom in on other messages such as "We don't seem to have your military records".

andaleliz commented 1 year ago

I think what you're referring to isn't in a modal component though. I believe this specifically impacts modals, but it's not sitewide since the crisis line modal allows for gesture zooming.

SKasimow commented 1 year ago

Notes: Is this an issue specific to Profile modals - if so we can address. If not, talk to Design system folks.

Compare against Crisis modal and see if it uses the legacy react modal component.

joshkimux commented 1 year ago

@SKasimow , this is something that could be reassigned to CAIA if it's a global issue! @coforma-terry for awareness

andaleliz commented 1 year ago

Hi @joshkimux! Sharon isn't working with us anymore. I'm not sure why she just unassigned herself without assigning it to anyone else. Thanks for rescuing this.

I just checked 2 non-profile modals - the crisis line, and the sign in. Crisis line does allow for zooming in, but the sign-in modal does not. On account of that, I'm going to call this a global issue. Who can I add as an assignee so it gets tracked with CAIA work?

joshkimux commented 1 year ago

I got you covered there! Re-assigning as a CAIA task

coforma-terry commented 1 year ago

@joshkimux - beat me to it - thanks!

SarahKay8 commented 1 year ago

Hi @andaleliz! May I have a staging link so I can test this out?

andaleliz commented 1 year ago

@SarahKay8 sorry about that - it's staging.va.gov. Here's the staging user list, in case you need that too.

I also updated the description so it's included there now.

SarahKay8 commented 1 year ago

Got it thanks! @andaleliz

SarahKay8 commented 1 year ago

Hey @andaleliz! Tested this out and I cant use ctrl +mouse wheel to zoom in on desktop on Windows + Chrome. I also cant use the pinch zoom method either. I'm not sure if we need to remove the touch-action property to get this to work, because the viewport settings look right and the initial-scale is set to 1.0. I'm going to create a bug ticket and see if I can sync with the devs over at DST in order to remediate this. Should we close this original ticket out or leave open?

RLHecht commented 1 year ago

Closing this ticket as SK is going to create a new bug ticket.