department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

526ez keyboard only e2e tests (step 2 Disabilities, non-BDD) #48325

Open sortizsh opened 2 years ago

sortizsh commented 2 years ago

Value Statement

As a I want to So that


Background Context

This commit introduces keyboard-only e2e tests for Chapter 1 (Veteran Details) of the 526ez form. It is scoped to the experience of a non-BDD user. In future commits, we will introduce tests for the remaining 3 chapters. Then we may introduce tests covering the experience of a BDD user, if the team believes it is worth the time. Currently, the regular e2e tests for 526ez do not cover the experience of a BDD user. See https://github.com/department-of-veterans-affairs/vets-website/blob/8e3923d906a3427570d234d6d329f2fd6c2f20f8/src/applications/disability-benefits/all-claims/tests/all-claims.cypress.spec.js#L39. These tests were commented out last year, in an unrelated PR. See https://github.com/department-of-veterans-affairs/vets-website/pull/18964/files#r719926550.

This commit also introduces a few custom cypress commands (tabToElementAndPressSpace and tabToGoBack) and proposes that one existing command be deprecated (tabToInputWithLabel).

Original issue(s)

department-of-veterans-affairs/va.gov-team#41632

Acceptance Criteria

Designs and Build Notes

https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/products/disability/526ez/526-overall-flow.md#disabilities

Definition of done

sortizsh commented 2 years ago

relates to Chapter 1 https://github.com/department-of-veterans-affairs/vets-website/pull/22220