department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
284 stars 206 forks source link

Staging: When VATS DS = Yes Last Seen 12/36 - F/E Clinic is Still Filtering Clinics where vet has been seen - Not All Clinics Display #48768

Open marcynadeau opened 2 years ago

marcynadeau commented 2 years ago

BLUF: The front end code is checking against the clinics where user has been seen in the past 12/36 month and matching it with clinics that are open for direct scheduling. Per Kay Lawyer, this filter should be removed. "Any clinic in that stop code, not just one (clinic) they have been seen in".

Note the filter only exists on if VATS is set to Last Seen within 12/36 mos. If VATS is set to Yes, Any there is no clinic filter.

Due to this logic veterans may not be able to direct schedule.

Scenario #1 NT15KIDYS3, Fort Collins: Site has last seen within 12/36 set for a type of care and only one clinic configured for direct scheduling and veteran has NOT been seen at the child site/clinic but has been seen at clinic in that stop code at the Parent site then veteran will NOT be able direct schedule. This is due to the logic above.

Scenario #2 INT11Optom, Dayton; Site has last seen within 12/36 set for a type of care and two clinics configured for direct scheduling and veteran has past appointment in one of those clinics while both should display only the clinic where the veteran has been seen in the past displays. Veteran is limited in direct scheduling choices due to logic above.

Flow6Optom Test Data Set UP
john.morrison@id.me: Dayton: Day Comp & Pen Optometry 09/20/2021@08:00 Act Req/Checked In

VATS DAYTSHR - Optometry Dayton: DS= Yes 36 month. Request = Yes 12. Clinics configured.

Two Clinics configured for Direct Scheduling:

  1. DAY COMP & PEN OPTOMETRY/C&P OPTOMETRY 1184
  2. DAY OPTOM/CONTACT LENS/ OPTOM/CONTACT LENS 3294

Steps to Recreate:

  1. Login as john morrison, select start scheduling, select Eye, Select Optometry. Select Dayton.

Results Expected:
Choose a clinic below or request a different clinic for this appointment.(*Required) C&P OPTOMETRY OPTOM/CONTACT LENS I need a different clinic

Results Seen: Choose a VA clinic Your last optometry appointment was at C&P OPTOMETRY: Dayton VA Medical Center 4100 West Third Street Dayton, OH 45428-9000

Main phone: 937-268-6511 (TTY: 711)

Would you like to make an appointment at C&P OPTOMETRY?(*Required)

Yes, make my appointment here No, I need a different clinic

https://staging-api.va.gov/vaos/v2/eligibility?facility_id=984&clinical_service_id=optometry&type=direct

{data: {id: "58ce", type: "patient_metadata",…}} data: {id: "58ce", type: "patient_metadata",…} attributes: {decisionDate: "2022-10-25T12:19:52.735194Z", clinicalServiceId: "optometry", type: "direct",…} clinicalServiceId: "optometry" decisionDate: "2022-10-25T12:19:52.735194Z" eligible: true id: "58ce" type: "direct" id: "58ce" type: "patient_metadata"

https://staging-api.va.gov/vaos/v2/locations/984/clinics?clinical_service=optometry {data: [{id: "1184", type: "clinics",…}, {id: "3294", type: "clinics",…}]} data: [{id: "1184", type: "clinics",…}, {id: "3294", type: "clinics",…}] 0: {id: "1184", type: "clinics",…} attributes: {vistaSite: 984, id: "1184", serviceName: "C&P OPTOMETRY", physicalLocation: "BLDG 310, ROOM 9",…} char4: null id: "1184" patientDirectScheduling: true patientDisplay: true phoneNumber: null physicalLocation: "BLDG 310, ROOM 9" primaryStopCode: 408 primaryStopCodeName: "OPTOMETRY" secondaryStopCode: 450 secondaryStopCodeName: "COMP & PENS (C&P) EXAMS" serviceName: "C&P OPTOMETRY" stationId: "984" stationName: "DAYTSHR -Dayton VA Medical Center" vistaSite: 984 id: "1184" type: "clinics" 1: {id: "3294", type: "clinics",…} attributes: {vistaSite: 984, id: "3294", serviceName: "OPTOM/CONTACT LENS", physicalLocation: "BLDG 330, 6 NORTH",…} ### this clinic should display to patient char4: null id: "3294" patientDirectScheduling: true patientDisplay: true phoneNumber: null physicalLocation: "BLDG 330, 6 NORTH" primaryStopCode: 408 primaryStopCodeName: "OPTOMETRY" secondaryStopCode: 449 secondaryStopCodeName: "FITTING & ADJSTMNTS 2ND ONLY" serviceName: "OPTOM/CONTACT LENS" stationId: "984" stationName: "DAYTSHR -Dayton VA Medical Center" vistaSite: 984 id: "3294" type: "clinics"

JohnMorrison_Otpometry.png

simiadebowale commented 2 years ago

@beth-wodzinski can you test if this defect has been fixed - Thank you

beth-wodzinski commented 2 years ago

I was unable to try this with the original patient and location due to an issue in DAYTSHR.

I tried with patient claudia.c.lapomarda@id.me in Cheyenne and Nutrition. In short, if VATS is set to YES, ANY, then both Cheyenne nutrition clinics are presented for direct scheduling. If I enter prior appointments, and set VATS to 12 or 36, only the clinic where the patient had an appointment is presented for scheduling. See attached spreadsheet for details.https://app.zenhub.com/files/133843125/5a2044fa-ad5b-4f98-a017-1e57f7443b4d/download

Simi checked and says it's filtering because "it looks like for nutrition, patientHistoryRequired is set to true for direct scheduling this is why the FE is filtering"

However, that's the whole point of this ticket. Per Kay Lawyer, this filter should be removed. "Any clinic in that stop code, not just one (clinic) they have been seen in".

This does not pass testing.

@marcynadeau @simiadebowale @ldelacosta

ldelacosta commented 2 years ago

This will not be part of go-live for VAOS-v2/Acheron. We will isolate the work from V2/Acheron code.

cc: @marcynadeau @beth-wodzinski @simiadebowale @JRRoof

simiadebowale commented 2 years ago

Hey @beth-wodzinski , After further analysis: It's been determined that: If VATS setting is set to yes any, FE DOES NOT filter clinics. If VATS setting is set to 12 months. FE filters by 36 months. If VATS setting is set to 36 months. FE filters by 36 months.

This was done this way because V0 currently filters by 24months. If the business decides to prioritize this change, we can start work to support filtering by 12 months as well. cc: @marcynadeau @ldelacosta

ldelacosta commented 1 year ago

@simiadebowale - Before implementing a change, we will need to review the results in the review instance to show when there are multiple clinics.

ldelacosta commented 1 year ago

Moving this ticket to blocked for now since our team is focusing on the PI 1 2023 priorities. We might squeeze this work in sprint 6 or if anyone has the bandwidth to pick up the work (TBD).