search

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 202 forks source link

Cleanup puma config env vars #50061

Open LindseySaari opened 1 year ago

LindseySaari commented 1 year ago

Description

WEB_CONCURRENCY and PUMA_THREADS are the current env vars that we use for the vets-api EKS deployment for puma. Staging Example. The default ones in puma are PUMA_MIN_THREADS AND PUMA_MAX_THREADS and the number of workers = WEB_CONCURRENCY We could probably just use use ENV vars instead of the three lines at the top of config/puma.rb. This would be a small cleanup task.

laineymajor commented 1 year ago

If this is a 'just do it' task, we can take this on over the double-sprint... BUT if it's more involved, this can wait.

laineymajor commented 1 year ago

Should this be a CoP ticket? @laineymajor @LindseySaari see if this is something Gia would be interested in... for exposure.