department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 203 forks source link

Modify asynch Midpoint Review response and appointment #51401

Closed shiragoodman closed 1 year ago

shiragoodman commented 1 year ago

User Story

As a VFS team member, I want to be given current, accurate guidance on asynch midpoint reviews so that I'm not completing unnecessary tasks.

Assignee: @sterkenburgsara Peer Reviewer: @allison0034

Description

The Slack response for asynch Midpoint review requests is the same as synchronous Midpoint Review requests. It states:

Your review is confirmed for January 5, 2023 1:30 pm ET. Check off the VFS actions in the ticket including:

Note: if you do not provide artifacts or we do not know which pages are included in the review at least two days prior, we will reschedule the review.

The first bullet is not applicable for a midpoint review and the operational guidance should be modified so Governance team members are not stating that for asynch.

In addition, the appointment that gets sent out still has "Zoom Meeting" in the location of the appointment. This is default from Calendly and should be deleted when the appointment is sent out to the Midpoint Review distribution list.

Impacted Artifacts

Midpoint Review - Moderator Responsibilities Collaboration Cycle Kickoff - Moderator Responsibilities

Tasks

Peer Review

To be completed by peer reviewer

Acceptance Criteria

How to prepare this issue

Refinement

shiragoodman commented 1 year ago

@sterkenburgsara please be sure to document your tasks and/or steps taken. And feel free to modify the AC if you feel it does not correctly capture the goal of the modification.

sterkenburgsara commented 1 year ago

@shiragoodman also adding the GH ticket as an additional artifact to modify. We will need to provide some messaging in the first checkbox under "VFS actions" in midpoint section to indicate that inviting additional attendees is only a requirement for a synchronous midpoint review.

shiragoodman commented 1 year ago

sounds good, @sterkenburgsara !

sterkenburgsara commented 1 year ago

@allison0034 ready for your review

allison0034 commented 1 year ago

@sterkenburgsara @shiragoodman I have a question. For this task...

Modify language in midpoint code block on Collab Cycle Kickoff Moderator Responsibilities page: edit the "before meeting" VFS actions to indicate that the "add guests" step is not applicable for asynchronous reviews.

I am wondering if they may want to add guests to the invite so everyone on their team knows when their review is. Just like we add our group email still, even tho we do not attend. What do you think? I do not think we have heard anyone complain about async reviews and this being an issue? Maybe we could change the language but I do not think we need to since we say no meeting will take place.

allison0034 commented 1 year ago

@sterkenburgsara @shiragoodman I would also add something to the Slack thread reply. I know Matt Dingee asked why we still scheduled the async reviews. Maybe something like...

Your asynchronous review is confirmed. No meeting will take place. Governance team members will provide feedback by EOD on Date, Time. Check off the VFS actions in the ticket including:

Note: if you do not provide artifacts or we do not know which pages are included in the review at least two days prior, we will reschedule the review.

sterkenburgsara commented 1 year ago

@allison0034 These are great insights. To Matt's point about why we even schedule async midpoint, honestly it's a valid question. I agree that is confusing! But if we are going to edit and say in Slack message that no meeting will take place, isn't it odd then to have a calendar invite & ask the team to invite people?

allison0034 commented 1 year ago

@sterkenburgsara yeah maybe we add more to it like this is a placeholder or something. I think the whole team would want to know when the review is happening so they know when to expect feedback. They wont know when the meeting is happening unless they have it on their calendar. Think of it as a reminder, not an event.

Same reason we add our group to the invite even tho there is no meeting.

allison0034 commented 1 year ago

@sterkenburgsara I guess you could remove it and just assume the PM will forward the invite to anyone they want to get the reminder

sterkenburgsara commented 1 year ago

@allison0034 that makes sense. I'll follow your recommendations.

sterkenburgsara commented 1 year ago

@allison0034 I removed the text about "inviting guests to the review" not being applicable so that teams can decide for themselves like you suggested. Also updated Slack message guidance per your suggestion. Can you review again?

allison0034 commented 1 year ago

@sterkenburgsara looks good, you can close!