department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

[PM] 10-10EZ - Household Optimization: Complete QA on the new changes #51641

Closed hdjustice closed 1 year ago

hdjustice commented 1 year ago

Background

Ad development wraps up, we need to begin QA on the changes to the Household section of the 10-10EZ

Resources

Tasks

Acceptance Criteria

hdjustice commented 1 year ago

Test Case B: the Financial Disclosure prep page lists "2022" (twice) - Is the expectation that this needs to be updated every year? ANSWER: Yes, this will require annual updates. This was to address the uncertainty and ambiguity around "Last year's" or "Last calendar year" references

image

image

hdjustice commented 1 year ago

Use Case C: The Spousal financial support question is prompting, even though I answered YES that the spouse lived with the Veteran last year and has the same address

image

image

jessicastump commented 1 year ago

I put some content edits found so far during a first review of staging and new content edits that we have still been getting to this ticket: [FE] 10-10EZ Content changes household section - Post QA #57959 Let me know if I should put edits here and keep that ticket only for new things the content team gives us.

hdjustice commented 1 year ago

@jessicastump - No, let's keep those content edits in that ticket. This one can be for functionality defects. I could actually move my "bold" comments to that ticket

mkerns1 commented 1 year ago
# Test Case ID Test Description Pass/Fail Bug ID (if any) Comments
A TC-A Applicant does not want to disclose their financial information Pass On the confirmation step, the button says "Confirm" not "continue.
B TC-B Applicant wants to disclose their financial information, is not married, and has no dependents Pass Looks good to me!
C TC-C Applicant wants to disclose their financial information, is married, and has no dependents; lives with spouse Pass BUG-001 When selecting yes to both spouse questions the next step in the form indicates conflicting information. I selected "yes" i lived with my spouse all of 2022 and the next step is the spouse's financial support. BUG TICKET #59034 created. UPDATE: BUG TICKET #59034 Resolved.
D TC-D Applicant wants to disclose their financial information, is married, and has no dependents; does not live with spouse, does not provide financial support Pass Why are the Income data points note formatted but the Deductible expenses data points are? ADDED This finding to #57959 content ticket
E TC-E Applicant wants to disclose their financial information, is married, and has no dependents; does not live with spouse, does provide financial support Pass Looks good to me!
F TC-F Applicant wants to disclose their financial information, is married, and has two dependents; lives with spouse Pass BUG-002 After adding Dependents Annual Income information and clicking continue the form breaks and reveals this error message in the console: instrument.js:109 TypeError: Cannot read properties of undefined (reading 'first'). BUG TICKET #59041 created. UPDATE: BUG TICKET #59041 Resolved.
G TC-G Applicant wants to disclose their financial information, is married, and has at least one dependent; does not live with spouse, does not provide financial support Pass BUG-002 After adding Dependents Annual Income information and clicking continue the form breaks and reveals this error message in the console: instrument.js:109 TypeError: Cannot read properties of undefined (reading 'first') UPDATE: BUG TICKET #59041 Resolved.
H TC-H Applicant wants to disclose their financial information, is married, and has at least one dependent; does not live with spouse, does provide financial support, does not live with dependent, does provide financial support Pass BUG-002 After adding Dependents Annual Income information and clicking continue the form breaks and reveals this error message in the console: instrument.js:109 TypeError: Cannot read properties of undefined (reading 'first') UPDATE: BUG TICKET #59041 Resolved.
I TC-I Applicant wants to disclose their financial information, is not married, and has at least one dependent Pass BUG-002 After adding Dependents Annual Income information and clicking continue the form breaks and reveals this error message in the console: instrument.js:109 TypeError: Cannot read properties of undefined (reading 'first') UPDATE: BUG TICKET #59041 Resolved.
jessicastump commented 1 year ago

I went through the form a couple of times (most cancelled out in error mentioned below, but was able to submit one app successfully with one dependent) and could not replicate error below on screen but realizing the note said "is in console"...so perhaps it was occurring.

message in the console: instrument.js:109 TypeError: Cannot read properties of undefined (reading 'first')

What I did encounter: when in the modals and canceling adding/editing a dependent, the page would blank out and I would have to start the application over. See screenshot below. screencapture-staging-va-gov-health-care-apply-application-household-information-v2-dependent-information-2023-05-22-12_08_13

Additional notes

hdjustice commented 1 year ago

We have had reports from previous research participants that the date numbers jump around/change unintentionally after input. We haven't talked much about the "Memorable date" component, but I think we might have decided that it would be a whole-form change and should not be part of this work.

hdjustice commented 1 year ago

and to confirm that the "blank" screen (that you captured above) is what @mkerns1 described exactly. It appears we have a few bugs to create here. I will work on that this week and we can review next week when @longmd returns.

jessicastump commented 1 year ago

Ticket #59397 created for this change

The card used for reviewing dependents has some changes needed, see notes from Design Council meeting (note, no final decision or next steps were listed). Experimental Ticket

Updated image below. DSC guidance to not horizontal align as items on the right are often missed with magnification settings. Design updates include a stacked mobile friendly layout:

card design

In staging:

Screenshot 2023-05-26 at 8 25 29 AM
hdjustice commented 1 year ago

Ticket #59296 created for this BUG

Use Case F:

hdjustice commented 1 year ago

QUESTION: (ANSWERED in comment below this one) If the dependents are edited, originating from the Review Page, and the applicant DOES NOT hit the Update Page button on the Review page after making edits, do they take affect still or revert back to the original input?

image

longmd commented 1 year ago

QUESTION: If the dependents are edited, originating from the Review Page, and the applicant DOES NOT hit the Update Page button on the Review page after making edits, do they take affect still or revert back to the original input?

image

@hdjustice , the edits do take place. The "Update Page" button simply takes that field out of edit mode. The edits are already committed once you come back to the review page.

hdjustice commented 1 year ago

Ok cool, I was thinking about folks who may not notice that Update page button as something to be done. Thank you!

hdjustice commented 1 year ago

All QA has been completed and all defects have been resolved.