COE | Fix hard coded parts of the form - Githubissues

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:

https://depo-platform-documentation.scrollhelp.site/index.html

284 stars 206 forks source link

COE | Fix hard coded parts of the form #53281

Open saderagsdale opened 1 year ago

saderagsdale commented 1 year ago

Value Statement

As a dev I want to remove hardcoded content So that the code is easier to maintain.

Background Context

Tech-debt work. Before @data-doge had to move off COE, they were in the middle of transitioning some hard-coded changes we had made to the COE schema on the front end, into our vets-json-schema gem. Here are some breadcrumbs for that work: https://github.com/department-of-veterans-affairs/va.gov-team/issues/53281; https://github.com/department-of-veterans-affairs/vets-website/pull/23372; https://github.com/department-of-veterans-affairs/vets-api/pull/11075; https://github.com/department-of-veterans-affairs/vets-json-schema/pull/748.

Tasks

[ ] Task
[ ] Task
[ ] Task

Acceptance Criteria

[ ] AC
[ ] AC
[ ] AC

saderagsdale commented 1 year ago

@data-doge jot in task details

steele-lm commented 1 year ago

@fred-khoury-oddball It looks like this ticket was drafted but never refined. Have you uncovered anything that should be called out?

data-doge commented 1 year ago

@fred-khoury-oddball -- See https://github.com/department-of-veterans-affairs/va.gov-team/issues/60243 ("Fix hard-coded parts of the COE form")