[eFSR] Functionality updates for FSR

[mgleo]

Issue Description

This Work in Progress ticket is a placeholder and will contain a list of functionality updates that need to be made on VA.gov by Front End team. @Dr-Pongo will create individual additional Front End tickets.

---

Tasks

• [x] Remove other checkbox option from Veteran other income and Spouse's other income and add additional update/add pages to this list loop to mimic Other Assets functionality. Ticket: #56738

• [x] Change back/continue buttons to cancel or add/update when adding or editing items from a mini summary card list. When adding item directly in the flow of the form (example: [first vehicle] (https://preview.uxpin.com/f43733391f52c409c4d3152e9a4b101a392e29df#/pages/161460760/simulate/sitemap)), keep back/continue buttons. Ticket: #56739

• [x] Vehicle input: Errors aren't shown when user doesn't fill out required field. Ticket: #56741

• [x] Add correct conditional disabled functionality to Current Year and Month fields for the employment history pages for spouse and the veteran when I currenlty work here checkbox is selected. Here's the slack thread for more context. Ticket #57342

• [x] Installment contracts and other debt > summary card Only show fields that the user has filled out on summary cards - Ticket #57343
• [x] All input fields - Update length of input fields to match designs. See discussion on Slack. Ticket #57345

Design/Content needed: (Can be added after Sprint 98- not launch blocking)

• [x] Veteran Employment History > Current job income Add an Additional Info component that explains how to calculate monthly income
• [x] Veteran employment history > payroll deductions Add an Additional Info component that explains how to check for payroll deductions and calculate them from paystub
• [x] Veteran employment history > payroll deduction amounts Add an Additional Info component that explains how to check for payroll deductions and calculate them from paystub
• [x] Household expenses > summary Page is missing, needs to be added.
• [x] Household expenses > installment contracts/credit card bills Change order of installments and credit card bills steps so that credit card bills comes first and installment contracts comes next.
• [x] Vehicle Summary Page Remove index number from aria-label for vehicle mini-summary page edit/delete buttons; it's confusing from a screen reader standpoint to read Edit 1989 BMW 325ix 0 or Edit 2004 Honda Accord 1 Saw that the index was added to prevent confusion if there were dupes, but it reads strangely to have a number, is there something else we can do? #58973
• [x] Add Employment Record Required label on Employer Name doesn't trigger error when you click the Add Employment Record button, can skip it even though it's a required field. #58974
• [x] Back and continue buttons aren't showing anymore when you add an initial employment history or vehicle. Seems like this is happening on all the pages. Not sure if the functionality changed or not. (buttons exist, just not labeled correctly) #58975
• [x] H3 styled as h4 update #58959
• [x] Add a credit card bill Tried to add credit card bill (clicked cancel like it wasn't going to be added; and went to a blank screen). #58977
• [x] Exploration: NaN is appearing on mobile (Example: Veteran Benefits Summary page). #58978
• [x] Exploration: Two mobile users were unable to submit form using eFSR. #58979
• [x] Contact info > Edit phone number Remove extension field #58980
• [x] Spouse employment > Monthly income question Required field doesn't work, can press continue without filling out the field. #58981
• [x] Recreational vehicles review page is missing update button.
• [x] Review page spouse benefits and recreational vehicles are missing $ symbol in review mode.
• [x] Contact info Typo on Contact Info page, says "Supplemental Claim"

Acceptance Criteria

• [x] Frontend team will create tickets based on these updates

[HeatherRienks]

@Dr-Pongo - these tickets are ready to be created! :)

[HeatherRienks]

@Dr-Pongo - of all 3 tasks listed above, please prioritize creating a ticket for Task 1 listed above: "Remove other checkbox option from Veteran other income and Spouse's other income and add additional update/add pages to this list loop to mimic Other Assets functionality."

Thanks!

[Dr-Pongo]

Task 1 ticket: Other income summary page addition (Veteran & Spouse) #56738

[Dr-Pongo]

Remaining tickets for tasks

Mini summary update page content #56739 Vehicle input error messages #56741

[josephrlee]

@Dr-Pongo, I just added a new functionality task into the description for y'all based on the convo in Slack to update the look and feel of disabeled field if a user selects that this is their current job.

[HeatherRienks]

@josephrlee @mgleo @charlottecesana - FYI, @Dr-Pongo will be creating 3 tickets for the Tasks noted above: 1 -Add correct conditional disabled functionality to Current Year and Month fields for the employment history pages for spouse and the veteran when I currently work here checkbox is selected.

2 - Installment Contracts and other debt summary card

3 -Update length of input fields to match designs

Thanks!!

[Dr-Pongo]

Added conditionally disable month/year FE ticket #57342

[Dr-Pongo]

Added installment contract summary card update FE Ticket #57343

[Dr-Pongo]

Added input field width FE Ticket #57345

[mgleo]

Additional Info Content/Design Ticket: 57389

[josephrlee]

@Dr-Pongo, just added a new task to this ticket regarding adding the mini-summary page for Household Expenses!

[HeatherRienks]

FYI- per 5/8/23 convo, we do NOT need Household Expenses task.

[josephrlee]

@Dr-Pongo, just added the new task to update the order of contract installments/credit card bills so that credit card bills comes before installment contracts.

[Dr-Pongo]

#58160 Ticket created for installment contract / credit card bill ordering

[josephrlee]

@Dr-Pongo, added a few more tasks that came out of our assistive tech pilot session we had. I can handle the h4 to h3 issue for the Mini Summary Cards, but for the rest, y'all will have to take on. Also, happy to chat through it more with you as well!

cc: @mgleo @HeatherRienks @charlottecesana

[Dr-Pongo]

New Tickets Created:

• [eFSR] aria labeling mini summary cards #58973
• [eFSR] Bug -Employment History required not triggering error #58974
• [eFSR] Navigation content update #58975
• [eFSR] Bug -Add Credit Card Bill cancel button #58977
• [eFSR] Bug -Veteran Benefits Summary page NaN #58978
• [eFSR] Bug -Investigate submission issues during testing #58979
• [eFSR] Contact information mobile number extension #58980
• [eFSR] Bug - Required Field Spouse Employment history monthly income #58981

[josephrlee]

@Dr-Pongo Created a couple more tasks after doing the accessibility testing that are not accessibility-related but are minor bugs nonetheless.

[HeatherRienks]

@Dr-Pongo- would you be able to add these tickets in (so we can possibly add them to our new Sprint tomorrow? :) Thanks!

cc: @josephrlee

[Dr-Pongo]

@HeatherRienks I'll add them first thing tomorrow!

[HeatherRienks]

Thank you @Dr-Pongo!

[Dr-Pongo]

Created:

• [eFSR] Update recreational vehicle on review page #59851
• [eFSR] Add dollar sign to spouse benefits on review page #59852
• Contact Info typo fixed in #24435

[mgleo]

@HeatherRienks @Tom-Davis closing this ticket