[Components and pattern standards] Design components or patterns don't align with Design System guidelines. (04.07.1)

shiragoodman commented 1 year ago

General Information

VFS team name

VA Online Scheduling (VAOS)

VFS product name

VA Online Scheduling

VFS feature name

Appointment List

Point of Contact/Reviewers

Allison Christman - @allison0034 - Design

*For more information on how to interpret this ticket, please refer to the Anatomy of a Staging Review issue ticket guidance on Platform Website.

Platform Issue

Design components or patterns don't align with Design System guidelines.

Issue Details

The "Go to your appointments" is styled as a button but it is navigation

Link, screenshot or steps to recreate

https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/platform/working-with-vsp/vsp-collaboration-cycle/staging-review-images/42025-Allison-040701.png

VA.gov Experience Standard

Category Number 04, Issue Number 07

Other References

WCAG SC 3.2.4 AA

Platform Recommendation

Navigation should be links and not buttons. Change to a link or action link

VFS Guidance

Close the ticket when the issue has been resolved or validated by your Product Owner
If your team has additional questions or needs Platform help validating the issue, please comment on the ticket
Some feedback provided may be out of scope for your iteration of the product, however, Platform's OCTO leadership has stated that all identified issues need to be documented and it is still your responsibility to resolve the issue.
If you do not believe that this Staging Review issue ticket is the responsibility of your team, comment below providing an explanation and who you believe is responsible. Please tag the Point of Contact/Reviewers. Governance team will research and will follow up.

ldelacosta commented 1 year ago

@shiragoodman - We reviewed this ticket and determined that VAOS does not own or manage this page/code. This ticket may need Public Website assistance to review. If you have any questions, please reach out. Thanks! cc: @JRRoof

shiragoodman commented 1 year ago

thanks @ldelacosta. In the future, please just let us know so can have the ticket reassigned opposed to just closing it.

@wesrowe could you take a look at this issue to see if it is your teams responsibility? @allison0034 FYSA

laflannery commented 1 year ago

@wesrowe this seems similar to the other ticket here, where you mentioned that it is going to be handled in the redesign that is underway. Do you know if this would also be updated at that time? Because if so I would recommend we handle this the same way - hold off for now and let this roll into the redesign

outerpress commented 1 month ago

@wesrowe @laflannery just checking in on this very old ticket as we try to clean up our board - not urgent on our end. Any plans on your side to update the login widgets to change the button to a link? The Cerner redirect was done but the login widget is still showing the issue. (If this is something our team should be doing, let me know. Thanks!)

laflannery commented 1 month ago

@mmiddaugh I believe these are the widgets that are not in our portfolio? Or that were going to be transfered? CC: @jilladams @FranECross

jilladams commented 4 weeks ago

Ownership hasn't transferred, but Michelle's working out details in hopes that we'll move parts:

department-of-veterans-affairs / va.gov-team