Migrate Telephone component for 686

[christinec-fftc]

Issue Description

Migrate the following uses of the Telephone component to use the new web components version GetFormHelp.jsx VeteranInformationComponent.js helpers.js

Front end tasks

• Ensure the page is styled according to design spec.
• Ensure the back end data from API is displayed in local and review instance
• Ensure unit tests are available.
• Ensure your code changes are covered by E2E tests
• Run axe checks using the Chrome or Firefox browser plugin
• Test for color contrast and color blindness issues
• Zoom layouts to 400% at 1280px width
• Test with 1 or 2 screen readers
• Navigate using the keyboard only

Acceptance Criteria

• [ ] Designer comments on this issue to approve page styling
• [x] Unit tests pass
• [x] E2E tests cover current code and regression
• [x] End-to-end tests show 0 violations.
• [x] The data returned matches API response (for given user or scenario)
• [x] All axe checks pass
• [x] All color contrast checks pass
• [x] All zoom testing passes
• [x] All keyboard checks pass
• [x] All screenreader checks pass

Appendix

Ensure your code changes are covered by E2E tests (expand)

- Add E2E tests if none exist for this addition/change. - Update existing E2E tests if this code will change functionality. - Include axe checks, including hidden content

Run axe checks using the Chrome or Firefox browser plugin (expand)

- Ensure no heading levels are skipped. - Ensure all buttons and labeled inputs use semantic HTML elements. - Ensure all buttons, labeled elements and images are identified using HTML semantic markers or ARIA roles. - Ensure form fields have clearly defined boundaries or outlines. - Ensure form fields do not use placeholder text. - Ensure form fields have highly visible and specific error states.

Test for color contrast and color blindness issues (expand)

- All text has appropriate contrast.

Zoom layouts to 400% at 1280px width (expand)

- Ensure readability and usability are supported when zoomed up to 400% at 1280px browser width - Ensure no content gets focused offscreen or is hidden from view.

Test with 1 or 2 screen readers (expand)

- Ensure the page includes a skip navigation link. - Ensure all links are properly descriptive. - Ensure screen reader users can hear the text equivalent for each image conveying information. - Ensure screen reader users can hear the text equivalent for each image button. - Ensure screen reader users can hear labels and instructions for inputs. - Ensure purely decorative images are not announced by the screenreader.

Navigate using the keyboard only (expand)

- Ensure all links (navigation, text and/or image), form controls and page functions can be reached with the tab key in a logical order. - Ensure all links (navigation, text and/or image), form controls and page functions can be triggered with the spacebar, enter key, or arrow keys. - Ensure all interactive elements can be reached with the tab key in a logical order - Ensure all interactive elements can be triggered with the spacebar, enter key, or arrow keys. - Ensure focus is always visible and appears in logical order. - Ensure each interactive element has visible focus state which appears in logical order.

---

How to configure this issue

• [ ] Attached to a Milestone (when will this be completed?)
• [ ] Attached to an Epic (what body of work is this a part of?)
• [ ] Labeled with Team (product support, analytics-insights, operations, service-design, Console-Services, tools-fe)
• [ ] Labeled with Practice Area (backend, frontend, devops, design, research, product, ia, qa, analytics, contact center, research, accessibility, content)
• [ ] Labeled with Type (bug, request, discovery, documentation, etc.)

[RakshindaAslam]

cc @RakshindaAslam

[RakshindaAslam]

Moved to icebox - to be handed over to the new 686 team.

[sortizsh]

There is also this documentation https://design.va.gov/about/developers/using-web-components#how-to-migrate-to-web-components

[tblackwe]

@christinec-fftc looking at the acceptance criteria:

• All axe checks pass
• All color contrast checks pass
• All zoom testing passes
• All keyboard checks pass
• All screenreader checks pass

Are those checkes automated already? If there is automated checks for these items, can you link us to some examples so we can understand how they are performed?

or do we need to manually verify these items?

[christinec-fftc]

There is definitely automation for a11y checks, but they may not be 100% foolproof so manual testing is still needed. The front end orientation has a great overview of these checks. There was a recent slack thread about making these sessions available asynchronously, but I haven't been able to access it yet. I'm happy to share what I've learned, but would still recommend going to the orientation. I will be going again myself. Feel free to setup some time if we want to walk through these checks together since the next session may be weeks out. There's also a little info on these checks here.

For zoom checks, product must be usable at 200%, 300% and 400% zoom. And for the screenreader check, we were told manually testing with 1 screenreader is sufficient.

[evansmith]

PR has been merged into main