Accessibility - 1010EZ: Upload button has odd HTML markup

[davidakennedy]

Issue description

I noticed some odd HTML on the upload button for documents in the military service section: <label id="root_attachments_add_label" for="root_attachments" class="vads-u-display--inline-block"></label>

The element is referencing a hidden <input>, which was flagged by one of my accessibility tools. As far as I can tell in my testing, this isn't causing an accessibility problem, but the HTML is odd. I'm wondering why we're wrapping a button with a label? The same component in the design system doesn't do that.

Remediation guidance

Remove label from around button, and/or follow markup pattern in design system.

Does this impact visual design?

No.

Relevant standards

N/A

[hdjustice]

Refinement Notes: Could be resolved if we decide to create a new component for uploading docs on the Review page (ticket #56759), however let's not create the component if it is not necessary. Decision TBD

[hdjustice]

FYI - some notes around volumes

Jan - April 2023

• CG POA - 382 (~95 per month)
  • Applicants went "back" to upload page from next page 42 times (~10 times per month)
• EZ DD214/etc - 735 (~183 per month)
  • Applicants went "back" to upload page from next page 21 times (~5 times per month)