department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

[Markup and meta data] HTML markup isn't valid. (09.01.1) #59255

Open shiragoodman opened 1 year ago

shiragoodman commented 1 year ago

General Information

VFS team name

Benefits Disability Experience Team

VFS product name

Disability Comp Application (21-526 EZ), Add Self Assessment Part A form information to BDD workflow

VFS feature name

Add Self Assessment Part A form information to BDD workflow

Point of Contact/Reviewers

Brian DeConinck - @briandeconinck - Accessibility

*For more information on how to interpret this ticket, please refer to the Anatomy of a Staging Review issue ticket guidance on Platform Website.


Platform Issue

HTML markup isn't valid.

Issue Details

On /start/, the "File a BDD disability claim online" link has an aria-describedby pointing to the "Learn more about the BDD program" link. That's not exactly how aria-describedby is intended to be used---in general, it's not supposed to reference IDs of interactive elements. What's happening is the first link is being read by screen readers with the combined text of the two links together, "File a BDD disability claim online learn more about the BDD program," then the next tab stop is the second link on its own. Definitely confusing if you don't have the visual cues of the screen to understand that they're separate links.

Link, screenshot or steps to recreate

Current code:

<a href="/disability/file-disability-claim-form-21-526ez/introduction" class="vads-c-action-link--green" aria-describedby="learn_about_bdd">File a BDD disability claim online</a>

<p id="learn_about_bdd" class="vads-u-margin-bottom--0">
    <a href="/disability/how-to-file-claim/when-to-file/pre-discharge-claim/">Learn more about the BDD program</a>
</p>

VA.gov Experience Standard

Category Number 09, Issue Number 01

Other References

WCAG SC 1.3.1_A

Platform Recommendation

Remove the aria-describedby. I think I understand what was originally intended here but it's not needed.


VFS Guidance

RakshindaAslam commented 1 year ago

This change will be included in the epic #5607 for Intro pages redesign.