department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
280 stars 195 forks source link

[Components and pattern standards] Design components or patterns don't align with Design System guidelines. (04.07.3) #59259

Open shiragoodman opened 1 year ago

shiragoodman commented 1 year ago

General Information

VFS team name

Benefits Disability Experience Team

VFS product name

Disability Comp Application (21-526 EZ), Add Self Assessment Part A form information to BDD workflow

VFS feature name

Add Self Assessment Part A form information to BDD workflow

Point of Contact/Reviewers

Allison Christman - @allison0034 - Design

*For more information on how to interpret this ticket, please refer to the Anatomy of a Staging Review issue ticket guidance on Platform Website.


Platform Issue

Design components or patterns don't align with Design System guidelines.

Issue Details

The pattern being used to update contact information is only updating the application and not profile. Also, there was no pre-filled information on the page (address/phone). That may have been because of the user file on staging but I was not sure.

Link, screenshot or steps to recreate

https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/platform/working-with-vsp/vsp-collaboration-cycle/staging-review-images/56612-Allison-040703.png

VA.gov Experience Standard

Category Number 04, Issue Number 07

Other References

WCAG SC 3.2.4 AA

Platform Recommendation

Update the contact info in profile. Follow the UI and layout for the "Know how their information is updated" in the design system (removing the gray background). Confirm contact information is being pulled into the text fields if it is on file.


VFS Guidance

christinec-fftc commented 1 year ago

I believe this issue was reproduced with test user 228. After logging into staging and going to their profile https://staging.va.gov/profile, getting this error. Possibly related. image.png

allison0034 commented 1 year ago

@christinec-fftc thanks that makes sense on why the info did not prefill!

lydiahooper commented 1 year ago

@allison0034 I'm not sure if this issue is about whether info in the profile is properly populating into 526 form (as far as we know that is working) or the fact that updates made in the application do not carry over to profile (the user is notified of this, as this annotated screenshot shows -- see area outlined in red) Screen Shot 2023-06-08 at 12.22.21 PM.png

allison0034 commented 1 year ago

@lydiahooper we prefer that you update the user profile and not just this application. You can see the pattern "Know how their information is updated". Does that help?

lydiahooper commented 1 year ago

@allison0034 thanks for clarifying.

@RakshindaAslam I have added this work to the MURAL board as an item to be prioritized.