department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
278 stars 194 forks source link

[Components and pattern standards] Design components or patterns don't align with Design System guidelines. (04.07.1) #59261

Open shiragoodman opened 1 year ago

shiragoodman commented 1 year ago

General Information

VFS team name

Benefits Disability Experience Team

VFS product name

Disability Comp Application (21-526 EZ), Add Self Assessment Part A form information to BDD workflow

VFS feature name

Add Self Assessment Part A form information to BDD workflow

Point of Contact/Reviewers

Allison Christman - @allison0034 - Design Allison Christman - @allison0034 - Design

*For more information on how to interpret this ticket, please refer to the Anatomy of a Staging Review issue ticket guidance on Platform Website.


Platform Issue

Design components or patterns don't align with Design System guidelines.

Issue Details

There is a gray background on the "Based on your separation date..." text. We currently do not have this style in the design system for an alert or featured text.

The "Supporting evidence" page is using conditional logic to display a wizard. The wizard is deprecated.

Link, screenshot or steps to recreate

https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/platform/working-with-vsp/vsp-collaboration-cycle/staging-review-images/56612-Allison-040701.png https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/platform/working-with-vsp/vsp-collaboration-cycle/staging-review-images/56612-Allison-040801-3.png

VA.gov Experience Standard

Category Number 04, Issue Number 07

Other References

WCAG SC 3.2.4 AA

Platform Recommendation

Remove the gray background.

Go to 1 question per page instead of displaying additional questions on a single page based on the answer.


VFS Guidance

lydiahooper commented 1 year ago

The "Based on your separation date..." text is being changed as part of intro pages redesign. The wizard on the "Supporting evidence" page is being redesigned as part of 4142 redesign. I'll close this ticket when both changes have been made.