department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

[Components and pattern standards] Design components or patterns don't align with Design System guidelines. (04.07.2) #59480

Open shiragoodman opened 1 year ago

shiragoodman commented 1 year ago

General Information

VFS team name

MHV

VFS product name

My HealtheVet

VFS feature name

Secure Messaging

Point of Contact/Reviewers

Brian DeConinck - @briandeconinck - Accessibility

*For more information on how to interpret this ticket, please refer to the Anatomy of a Staging Review issue ticket guidance on Platform Website.


Platform Issue

Design components or patterns don't align with Design System guidelines.

Issue Details

On /compose/, the "Edit list" element beneath the "To" field is coded as a button, but visually styled as a link. Styling a button as a link may cause issues for voice command users --- a user might expect the command "Click link" to highlight all of the links on the page to choose the link they want to select, and when "Edit list" isn't highlighted as an option they have to guess what the correct command should be.

Link, screenshot or steps to recreate

Currently coded as:

<button type="button" class="link-button edit-input-button">Edit List</button>

VA.gov Experience Standard

Category Number 04, Issue Number 07

Other References

WCAG SC 3.2.4 AA

Platform Recommendation

Maintain material honesty, with links navigating and buttons doing things --- both semantically and visually. If it's a <button>, it should look like a button so that users know what kind of element they're trying to use.


VFS Guidance

lichellebain commented 1 year ago

Jira ticket created: https://jira.devops.va.gov/browse/MHV-46070