[FE] My VA Claim Status EVSS > Lighthouse: Post-launch code cleanup

ajakabcin commented 1 year ago

Background

Once our update to the claim status widget is complete and we've fully migrated over to the Lighthouse endpoints instead of EVSS, we'll need to do the standard post-launch code cleanup: remove feature flag, update tests, etc.

Discuss with team: it might make sense to hold off on this cleanup until the EVSS service is deprecated in September?

Nov 15 update: there is an open PR on this

Tasks

[x] Remove feature flag from FE code for claim status widget to point to Lighthouse (my_va_lighthouse_claims)
[x] Remove feature flag from API code for claim status widget to point to Lighthouse (my_va_lighthouse_claims)
[x] Update tests as needed (?)

Acceptance Criteria

[ ] Claim status widget to point to Lighthouse (my_va_lighthouse_claims) feature flipper is removed from FE and API code and not visible on the feature flipper tool

Validation

Who can validate this ticket? (FE, BE, Design, PM)? Dev
How can this work be validated? confirm toggle is removed and tests are updated (if needed)

dellerbie commented 1 year ago

Pull request

ajakabcin commented 1 year ago

Swapping this to the backlog for now in favor of #66660

ajakabcin commented 1 year ago

Per @dellerbie, this work is more or less complete but we want to keep the flag available to us for a bit longer to make sure the migration is stable and we don't need a "roll back" (i.e. turn the feature off for users via the feature flag).

Marking with needs-refinement as well so we keep this in our sights.

DanielMiller-agile6 commented 10 months ago

I updated Derek's PR merged with latest code from main, and resolved a few errors: https://github.com/department-of-veterans-affairs/vets-website/pull/25974

Also added vets-api PR to remove the feature flag: https://github.com/department-of-veterans-affairs/vets-api/pull/14849

DanielMiller-agile6 commented 10 months ago

looks like the FE code has made it to staging. i've verified that calls are still being made to lighthouse and that UX appears to work as expected after removing the feature toggle UI code. After vets-api PR is merged, the actual toggle will be removed as well, but we'll need to manually remove from the DB as it deploys across environments (see comments in vets-api PR). Until then, the old my_va_lighthouse_claims flag shouldn't do anything, since all calls will now be made to lighthouse regardless of toggle state.

@ajakabcin let me know if anything looks "off" in staging :). I'll update this issue again once vets-api PR is merged and database entries are removed in order to verify removal from the toggler interface as well. I don't have permissions to change toggles on staging, but toggling them there will no longer have any effect.

department-of-veterans-affairs / va.gov-team