COE | List Loop Pattern Accessibility Fix

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:

https://depo-platform-documentation.scrollhelp.site/index.html

283 stars 204 forks source link

COE | List Loop Pattern Accessibility Fix #60756

Open Midge-dev opened 1 year ago

Midge-dev commented 1 year ago

Info:

Refer to department-of-veterans-affairs/va.gov-team#23562

Description:

[developers] ensure that the list loop pattern for previous military history accommodates unique accessible labels for past service fields. For example, if there are multiple "branch of service" dropdowns each of them must have a unique accessible label so screen reader users can easily tell them apart.

Acceptance Criteria:

[ ] Update aria labels so that each Period of Service and it's related inputs are distinguishable to screen readers

steele-lm commented 2 months ago

@fiorella-io I found this old ticket. Do we still need it or is this issue fixed with the updated designs?

fiorella-io commented 2 months ago

@steele-lm We will use the new list and loop pattern for military history, but Josh mentions dropdowns and adding aria labels here. I checked the military history page using the VA component checker, and those fields are highlighted as missing web components, so this should be fixed once we change them to v3 components.

We could add this acceptance criteria to our ticket regarding Step 3 of the COE form: Update aria labels so that each Period of Service and its related inputs are distinguishable to screen readers