department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

[FE] Notification Component: GA tracking on "manage your VA debt" seems incorrect #60845

Closed ajakabcin closed 1 year ago

ajakabcin commented 1 year ago

Background

While testing the notification component on My VA on staging, I was confirming our event tags and noticed that the "Manage your VA debt" link was showing an event tag associated with the date of the notification

Steps to Reproduce

  1. Log into staging with user 221
  2. Open console
  3. Right click the "Manage your VA debt" link for the notification triggered on May 25 to open the "current VA debt" page
  4. See in the console that the GA event is Navigation - Link Click - Thursday, May 25, 2023 - Thursday, May 25, 2023 (screenshot in resources section)

Tasks

Acceptance Criteria

Validation

Resources

Screenshot 2023-06-26 at 9 36 25 AM

allisonlu commented 1 year ago

The Design System team has a ticket in their icebox to implement analytics for the va-notification component: https://github.com/department-of-veterans-affairs/vets-design-system-documentation/issues/1803, so this issue will be blocked.

caw310 commented 1 year ago

DST will be working to add analytics to va-notification events. https://github.com/department-of-veterans-affairs/vets-design-system-documentation/issues/1803

ajakabcin commented 1 year ago

Bringing this down to a 0 and moving to sprint 14 until 1803 is complete and we can validate and resolve this

allisonlu commented 1 year ago

Can confirm that the close GA event is firing on staging for user 11!

Screenshot 2023-09-19 at 3 41 38 PM

ajakabcin commented 1 year ago

Closing as complete