department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 203 forks source link

Search box CSS bug on 404 page #61427

Open andaleliz opened 1 year ago

andaleliz commented 1 year ago

The search box on the 404 page has a styling error that is causing the input field and button to be equal widths. I saw this on Chrome desktop. If I manually resize my browser window it appears to be fixed at 768px and smaller screens, but when I use the Chrome device emulator I see it across all screen sizes.

You can visit this URL to check it out for yourself: https://www.va.gov/abcde, and here are some screenshots:

image image
wesrowe commented 1 year ago

From previous experience with search component rendering, this is in the design system realm. I recommend sharing with them.

andaleliz commented 1 year ago

@humancompanion-usds and @caw310 - sounds like this one is for your team. Do you need me to move it over to the vets-design-system-documentation repo? I checked there and it doesn't look like this has been reported yet.

caw310 commented 1 year ago

@andaleliz it can stay in this repo.

humancompanion-usds commented 1 year ago

@caw310 - This is likely related to the button work we've been doing thus I would group it with the other form elements for our upcoming swarm.

jamigibbs commented 1 year ago

The search input displaying on the 404 page is not a design system component although it probably should be updated to be va-search-input. The CSS issue reported is not present in the design system web component.

jamigibbs commented 1 year ago

It looks like this page might be coming from src/applications/dhp-connected-devices/components/PageNotFound.jsx and the codeowners are @department-of-veterans-affairs/digital-health-platform

Can someone from the @department-of-veterans-affairs/digital-health-platform help out with this?

caw310 commented 1 year ago

Removing from DST backlog since this isn't a DS component issue.