Open joshkimux opened 1 year ago
@joshkimux @eileen-coforma @Mottie to huddle on this one
I had a discussion about this with @joshkimux, and he suggests moving it to blocked for now. Two reasons:
I did some more testing here this sprint to see how things have changed. Here are some notes:
Point of contact
joshkimux
Severity level
1, Launchblocking
Details
The review answers page has several major focus management and error messaging issues which is consequence to its complex design. This includes, but isn't limited to:
va-alert
s announce updates within the shadow domh3
or first edit link (we need to discuss this in more detail)assertive
alerts conflict with one anotherassertive
alerts on the pageh2
step x of y instead of the uniqueh3
https://github.com/department-of-veterans-affairs/va.gov-team/assets/14154792/c80fc1f0-3228-4ec0-a797-570457af9e7a
Reproduction steps
Proposed solution or next steps
I'm not confident this is a problem worth attempting to solve downstream. This likely deserves more attention and review from accessibility specialists, designers, and engineers-- particularly to explore upstream solutions like a check answers page.
Several of these issues are sitewide, and should be escalated to the DST team (if they have not already).
Next steps
We could potentially look into fixes we can control and make now, but I would recommend against anything that requires too many resources / is too complicated if it won't fix more upstream problems at scale.
When I return from vacation I'll prioritize this as an issue to break apart with other specialists sitewide.
Update
@laflannery 's team is already using a new version of the check answers page that references the gov.uk pattern. It has undergone testing as a prototype, and exists as a sketch file recommended by the Design System team. They received design intent feedback to use this in the collaboration cycle.
Type of issue