department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

[Design, FE] 10-10EZ - Household section: Content updates from pre-staging review #61632

Closed hdjustice closed 1 year ago

hdjustice commented 1 year ago

Background

Per the latest content review in ticket #52920, the following updates need to be implemented:


FINANCIAL INFO YOU WILL NEED PAGE Sketch MUST Remove references of "your" and add in "annual".

Screenshot 2023-07-07 at 2 03 21 PM

SPOUSE ADDITIONAL INFORMATION PAGE https://staging.va.gov/health-care/apply/application/household-information-v2/spouse-additional-information https://www.sketch.com/s/da85cf44-4503-4e98-834e-ff068b242ef6/a/Eeeqyyd

Screenshot 2023-07-07 at 2 05 53 PM

SPOUSE FINANCIAL SUPPORT PAGE https://staging.va.gov/health-care/apply/application/household-information-v2/spouse-financial-support https://www.sketch.com/s/da85cf44-4503-4e98-834e-ff068b242ef6/a/ZVVJGwZ

SHOULD

Screenshot 2023-07-07 at 2 08 23 PM

ADD/REVIEW DEPENDENT PAGES https://staging.va.gov/health-care/apply/application/household-information-v2/dependents https://www.sketch.com/s/da85cf44-4503-4e98-834e-ff068b242ef6/a/AZxwR8r?annotation=4fa3c0d4-fe3a-4a06-bc58-9c914708a1c8

Changes to additional info component content - NOTE this is also used on the Review Dependents page and same updates need to be made there

Screenshot 2023-07-07 at 2 09 57 PM

CANCEL ADDING THIS DEPENDENT MODAL https://staging.va.gov/health-care/apply/application/household-information-v2/dependent-information?index=0 https://www.sketch.com/s/da85cf44-4503-4e98-834e-ff068b242ef6/a/bLLq59z

Screenshot 2023-07-07 at 2 12 07 PM

DEPENDENT EDUCATION EXPENSES INFORMATION PAGE Sketch

SHOULD: full-time or part-time student in 2022?

Screenshot 2023-07-07 at 2 13 17 PM

DEPENDENT ADDITIONAL INFORMATION PAGE https://staging.va.gov/health-care/apply/application/household-information-v2/dependent-information?index=0 https://www.sketch.com/s/da85cf44-4503-4e98-834e-ff068b242ef6/a/nQQldKk

Screenshot 2023-07-07 at 2 15 52 PM

DEPENDENT'S SUPPORT PAGE


DEPENDENT'S INCOME https://staging.va.gov/health-care/apply/application/household-information-v2/dependent-information?index=0 https://www.sketch.com/s/da85cf44-4503-4e98-834e-ff068b242ef6/a/WddpxZ0

Screenshot 2023-07-07 at 2 24 47 PM

REMOVE THIS DEPENDENT MODAL https://www.sketch.com/s/da85cf44-4503-4e98-834e-ff068b242ef6/a/dggqLRZ

Screenshot 2023-07-07 at 2 36 03 PM

INCOME PAGES - VETERAN AND SPOUSE https://staging.va.gov/health-care/apply/application/household-information-v2/veteran-annual-income https://staging.va.gov/health-care/apply/application/household-information-v2/spouse-annual-income https://www.sketch.com/s/da85cf44-4503-4e98-834e-ff068b242ef6/a/3oKK9zd?annotation=c767b014-309a-4c87-b07e-f41260cf7e0b https://www.sketch.com/s/da85cf44-4503-4e98-834e-ff068b242ef6/a/r9qq3VK

VETERAN INCOME:

Screenshot 2023-07-07 at 2 28 29 PM Screenshot 2023-07-07 at 2 28 38 PM Screenshot 2023-07-07 at 2 29 34 PM

SPOUSE INCOME:

Screenshot 2023-07-07 at 2 34 14 PM Screenshot 2023-07-07 at 2 34 21 PM Screenshot 2023-07-07 at 2 34 35 PM

DEDUCTIBLES https://staging.va.gov/health-care/apply/application/household-information-v2/deductible-expenses https://www.sketch.com/s/da85cf44-4503-4e98-834e-ff068b242ef6/a/JA88E27

Screenshot 2023-07-07 at 2 39 51 PM

Tasks

Acceptance Criteria

aliyahblackmore commented 1 year ago

Hi @hdjustice and @jessicastump just tracking that were some adjustments to feedback during our call earlier - they're tracked in the Sketch QA comments!

Summary here:

hdjustice commented 1 year ago

Got it, thanks @aliyahblackmore !

jessicastump commented 1 year ago

Hi! - @aliyahblackmore Please make sure that the Sketch QA page (MOBILE only for now - I will work on Desktop screens next) should have all MUST/SHOULD content changes made and accounted for. Everything is also in this ticket description and I added screen captures.

@hdjustice and @longmd - Pending Aliyah's confirmation, all content changes are in this ticket/Sketch QA page.

aliyahblackmore commented 1 year ago

Hi @jessicastump! I'll take a look at these later this evening. I'll comment in this ticket if there are any missing changes.

Thank you!

aliyahblackmore commented 1 year ago

Hi @jessicastump! I did a review of all of the screens with your edits to the must/should changes above/in the sketch comments. They look great.

Sharing two last changes below, once their made - this has my confirmation that everything is accounted for!

Thanks again for your continued collaboration on this work!

TWO LAST CHANGES pre-staging:

ONE - On the DEPENDENT'S SUPPORT PAGE, since this screen is only being shown if the Veteran has a dependent who is an unmarried child (we clarified in our conversation earlier this afternoon) then we should adjust the additional information header slightly to be this:

What we consider financial support for a dependent child

If my understanding here is not accurate re: the flow, there is still one small change to the component header - to put "dependent" after:

_What we consider financial support for a dependent_

This edit more closely aligns with the additional info component on the spouse financial support screen.

I tracked this on the sketch screen.

Screen Shot 2023-07-07 at 9 06 25 PM

TWO - On the DEPENDENT'S EDUCATIONAL EXPENSES PAGE, change "educational expenses" to "education expenses" I tracked this on the sketch screen

Screen Shot 2023-07-07 at 9 19 29 PM
jessicastump commented 1 year ago

@longmd - This ticket is ready with the final content must edits. I am working on updating the desktop screens in the Sketch file this am, but the mobile screens and this ticket has everything.

longmd commented 1 year ago

@jessicastump , are these only musts? If there are shoulds that we could knock out that are small, we can go ahead with those, too.

jessicastump commented 1 year ago

@longmd - Must and shoulds are both included here. The coulds will all be new tickets.

longmd commented 1 year ago

@jessicastump , on the cancel modal... do we need to adjust the description for cancelling an edit action to match that of the add action? Currently for edit it says This will stop editing {dependentName}. You will return to a list of any previously added dependents and your edits will not be applied.

longmd commented 1 year ago

@jessicastump , there is also still one spot where we reference "last year" instead of the actual year number in the dependent section. If your dependent didn't live with you last year, did you provide financial support?. Does that need to be changed to the year number, too, to be consistent with the entire rest of the section?

jessicastump commented 1 year ago

@longmd - For the cancel modal, yes there is new description text reading:

If you cancel adding this dependent, we won’t save their information. You’ll return to a screen where you can add or remove dependents.

@aliyahblackmore Can you please confirm if we should leave this question as is or change last year to in 2022:

If your dependent didn't live with you last year, did you provide financial support?

longmd commented 1 year ago

@jessicastump , we have a different description for canceling adding a new dependent and editing an existing dependent. My question is, do we need to change the description when you attempt to cancel editing--listed in my comment above--to more closely match that of the new description for canceling adding?

jessicastump commented 1 year ago

Thank you for calling this out! Direct sketch links below. Both should have the headline be a question and copy description is in the Sketch links:

Sketch file for Cancel EDIT modal Sketch file for Cancel ADD modal

aliyahblackmore commented 1 year ago

@aliyahblackmore Can you please confirm if we should leave this question as is or change last year to in 2022:

If your dependent didn't live with you last year, did you provide financial support?

Yes, change "last year" to "in 2022" cc: @jessicastump @longmd

longmd commented 1 year ago

@hdjustice / @jessicastump , these have been completed and are ready for your final review and signoff.

jessicastump commented 1 year ago

@longmd I went through staging a couple of times and I believe all content changes are accounted for!

hdjustice commented 1 year ago

I am good with this. Thank you both so much for the quick turnaround!