[Other - Accessibility] Odd NVDA handling of errors, may be USWDS component bug. (00.00.1)

shiragoodman commented 1 year ago

General Information

VFS team name

Veteran Facing Forms

VFS product name

21P-0847

VFS feature name

Point of Contact/Reviewers

Brian DeConinck - @briandeconinck - Accessibility

*For more information on how to interpret this ticket, please refer to the Anatomy of a Staging Review issue ticket guidance on Platform Website.

Platform Issue

No VA.gov Experience Standard for the issue found.

Issue Details

On required text inputs and memorable dates (but not radio groups), there's an odd behavior with NVDA where, if you attempt to continue with an invalid or missing response, the input label is read three times before reading the error message.

The impact here is minimal, but it could be annoying to a screen reader user.

Link, screenshot or steps to recreate

Video from testing with NVDA on Windows. The issue doesn't appear to happen with JAWS. Have not tested with VoiceOver or any mobile screen readers.

https://github.com/department-of-veterans-affairs/va.gov-team/assets/6844775/9e228b2b-b9b2-435d-a65a-7a77812ce159

VA.gov Experience Standard

Category Number 00, Issue Number 00

Other References

Platform Recommendation

I haven't been able to determine a cause, but I've got to think this is somehow a USWDS component bug. I checked an older form elsewhere on VA.gov and couldn't reproduce that behavior.

VFS Guidance

Close the ticket when the issue has been resolved or validated by your Product Owner
If your team has additional questions or needs Platform help validating the issue, please comment on the ticket
Some feedback provided may be out of scope for your iteration of the product, however, Platform's OCTO leadership has stated that all identified issues need to be documented and it is still your responsibility to resolve the issue.
If you do not believe that this Staging Review issue ticket is the responsibility of your team, comment below providing an explanation and who you believe is responsible. Please tag the Point of Contact/Reviewers. Governance team will research and will follow up.

jeana-adhoc commented 1 year ago

There seems to be a number of bug tickets filed with NVDA regarding the double/triple speaking issue I'm going to go through them and verify that our issue is similar and see if there are any suggestions on what to do about it. I also want to test the USWDS design system and see if things are being repeated there as well.

jeana-adhoc commented 1 year ago

~~I've confirmed that this seems to be only happening in our implementation of the component.~~

~~Both USWDS and VADS Storybook examples do not have this repeating text in NVDA.~~

I previously missed that this was happening when the error message is thrown. The above statements are not true as you cannot test the error messages on the USWDS design system website, and for VADS, the error messages in the design system examples are static. There's no way to trigger one to appear.

jeana-adhoc commented 1 year ago

In looking at this some more, I see that our mock-form that has a full name pattern where the label+ warning message is not repeated multiple times. The code appears to be the same across the two forms.

I tested this with @briandeconinck who helped identify some other weird NVDA behavior. If you start typing into the required field, and delete your text, it will read out the label in other un-wanted was as well. He also was able to recreate the repeated labels on our mock form (which is why I crossed out my finding above.

https://github.com/department-of-veterans-affairs/va.gov-team/assets/117098918/3b1604cc-c9cf-4e7e-9270-2194d27c8101

department-of-veterans-affairs / va.gov-team