department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

Staging Review [Print Styles Design] #6364

Open jonathanjnelson opened 4 years ago

jonathanjnelson commented 4 years ago

Steps to complete Staging Review:

Artifacts - please provide the following artifacts at least 2 days before scheduled review meeting

Meeting attendees from requesting team

Scheduling

Preferred dates or times:

3/5/20 - 4 PM - 5 PM EST 3/6/20 - 3 PM - 5 PM EST 3/9/20 - 2 PM - 3 PM EST, 4:30 - 5 PM EST

Additional Notes

During this collaboration point, you will receive feedback from the following practice areas: design, accessibility, content, QA, and optional: product, analytics, engineering, information architecture

meganhkelley commented 4 years ago

Hey @jonathanjnelson ! Can you please give a bit more context on what feedback you are looking for here, and what stage of the development cycle you are in? From the info you've provided, it looks like you are looking for feedback on the print styles as templates only — is that correct? Are there plans (by your team or another) to implement these on VA.gov?

With the assumption that you're just looking for feedback on the templates, I'll go ahead and get this scheduled with the following practice areas: design, accessibility, content, (and information architecture as optional). Because (I think) this does not detail actual implementation of these print styles, I will leave out: analytics, engineering, QA, and product. Future implementation would efforts would need to check back in as part of the VSP Collaboration Cycle for further review. Does that line up with what you're looking for and your expectations for this collaboration point?

Lastly, I'm having trouble getting a meeting in any of your suggested times with the full group. Would you be able to do Thursday 3/5 between 1:30 - 2:30 pm ET, or Tuesday 3/10 between 11:30 - 12 pm ET?

jonathanjnelson commented 4 years ago

Of course, I do apologize for being vague (I’ve never utilized a template like this before).

Yes, you are correct. Riley Orr and I are looking for feedback on print styles templates only. This is a side project we are working on, and the goal is to design the print stylesheet and standardize across all VA.gov pages (and eventually implement). With that being said, I feel that review with design, accessibility, content, (and information architecture as optional) makes sense at this point in the project.

It looks like Thursday 3/5 between 1:30 - 2:30 pm ET will work!

meganhkelley commented 4 years ago

Excellent! Scheduled for 3/5 @ 2 pm ET. Is there a DEPO product owner on yours or Riley's team who should be included?

jonathanjnelson commented 4 years ago

Thank you so much!

I would like to mention that we have met with Jennifer and Trevor multiple times. Just so I am clear, we would have two checkpoints?

Also, we don't have a product owner but I am going to check on that today.

meganhkelley commented 4 years ago

Oh, good to know @jonathanjnelson !

@1Copenut @jenstrickland — because y'all have already seen these print styles a fair bit it sounds like, your feedback for the 3/5 review can be optional.

Thanks all! LMK if you have any further questions. 👍

1Copenut commented 4 years ago

VSP accessibility comment for the print styles. Just one ✔️ Consider in the attached screenshot below. Please holler at me if you want to discuss further or have any questions.


Screen Shot 2020-03-10 at 11 22 32 AM

jonathanjnelson commented 4 years ago

Thank you for all the feedback on the designs. Riley made revisions and we’ve decided to move forward with the following designs and strive to implement in the Caregiver’s MVP.

Please let us know if you have any questions and concerns.

Thank you,

Riley and Jonathan

Caregiver confirmation - Desktop - v 02 Order confirmation - Desktop - v 02

meganhkelley commented 4 years ago

Hi @jonathanjnelson ! Was this ever implemented? We may have found a bug with the VA.gov logo appearing on this page in staging — https://dsva.slack.com/archives/CQH357ZTP/p1602626937141100

I'm not positive it's related to the work on print styles, but I thought I recognized the design from this work y'all had done. :)

It's a trivial bug, just looking for info!

cc @billfienberg

jenstrickland commented 4 years ago

It looks like it is a broken url — which is why the image isn't loading.

jonathanjnelson commented 4 years ago

@meganhkelley It was implemented for the 10-10CG. Let me know what I can do to assist.