department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

[a11y-defect-2]: Address component issues when user lives abroad on a military base #64038

Open coforma-jamie opened 1 year ago

coforma-jamie commented 1 year ago

Point of contact

Jamie Klenetsky Fay

Severity level

2, Serious. Should be fixed in 1-2 sprints post-launch.

Details

There are a number of issues with the address component. The component is used on many forms, and CH36 is a good example. This ticket lays out small, medium, and large fixes to the component from an accessibility point of view.

Any changes applied to this iteration of the address component should apply sitewide.

Small

When a user checks "I live on a United States military base outside of the county," there are two immediate issues that crop up:

The "country" field is disabled

image As explained in the form guidelines, there are two big issues with this:

  1. Disabled buttons don’t explain what’s wrong. They communicate that something is off, but very often that is not enough information. As a result, users are left wondering what’s actually missing, and consequently are locked out entirely.
  2. Disabled buttons can be unintentionally read out and accessed by mobile screen readers using touch controls.

The "APO/FPO/DPO" error message is incorrect

The error message says "City" is required, but the user isn't supposed to enter a city here: image

Medium

Select boxes used when radio buttons would be more appropriate

When a user checks "I live on a United States military base outside of the county," the "APO/FPO/DPO" and "State" fields are select boxes, even though they only have 3 options to select from: image

image

The select component guide notes that you should only use select "when a user needs to choose from about seven to 15 possible options and you have limited space to display the options." It's cognitively simpler to see a list of radio buttons when there's only a few options to select.

Large

Checkbox triggers conditional logic; is not "one thing per page"

When a user checks "I live on a United States military base outside of the county," some fields are removed, others are added. This can be confusing for folks, especially those using assistive technology, and goes against our "One thing per page" complete a sub task pattern.

Reproduction steps

  1. Go to the form
  2. Click "Start your application without signing in"
  3. Get to the second page, where you see the "I live on a United States military base outside the country," and check the box
  4. Click "continue" without filling in any fields to view the error messages

Proposed solution or next steps

When "I live on a United States military base outside of the country." is checked:

Small

The "country" field is disabled

The "APO/FPO/DPO" error message is incorrect

Medium

Select boxes used when radio buttons would be more appropriate

Large

Checkbox triggers conditional logic; is not "one thing per page"

References, articles, or WCAG support

No response

Type of issue

steele-lm commented 10 months ago

Some small improvements will be made as part of #68004 and #68002. Larger improvements will be handled at the design system level.

jeana-adhoc commented 4 months ago

@coforma-jamie et al, our team is fixing the error message in the forms library in this ticket.