search

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 198 forks source link

[a11y-defect-4]: URL in Privacy Act Statement isn't a proper link #64122

Open coforma-jamie opened 1 year ago

coforma-jamie commented 1 year ago

Point of contact

Jamie Klenetsky Fay

Severity level

4, Minor. Consider fixing or exploring in 2-4 sprints post-launch.

Details

In the Privacy Act Statement, there's a URL that isn't linked: image

URLs need to be actionable and tell the user where the link is taking them, according to the content style guide.

Reproduction steps

  1. Go to this page
  2. Click on "Apply for Veteran Readiness and Employment with VA Form 28-1900"
  3. Scroll to the bottom and click on "Privacy Act Statement"
  4. A modal will open - look for the unlinked URL

Proposed solution or next steps

We recommend changing this sentence that begins "Valid OMB control numbers can be...."

to "Valid OMB control numbers can be located on the OMB Internet Page (opens in new tab)."

References, articles, or WCAG support

  1. content style guide

Type of issue

Midge-dev commented 11 months ago

@coforma-jamie I dug a little deeper into this. It seems the OMB Info platform component generates this Privacy Act Statement by default. The link in question is also unlinked in the documentation examples - https://design.va.gov/components/omb-info

It appears we can pass our own "children" into the component allowing us to override the default statement with our own custom statement, however I haven't found any examples of where other teams are doing this anywhere else in the code yet. We can likely use this children method (I have not tested yet) if we want to design custom copy. Or we can reach out to platform about updating the component to address this.

cc: @tblackwe @steele-lm