[SW] Staging Review - Components or patterns don't align with guidelines, benefits (63674) (Post Launch)

[Tom-Davis]

During the Staging Review on 8/15/23 this post launch feedback was provided #63674

Platform Issue

Design components or patterns don't align with Design System guidelines.

Issue Details

On the disability compensation and pension benefits card, if the user clicks "Edit" they get a "Cancel" and "Update" button pair. The buttons have chevrons. In our design system these buttons do not have chevrons.

Link, screenshot or steps to recreate

VA.gov Experience Standard

Category Number 04, Issue Number 07

Other References

WCAG SC 3.2.4 AA

Platform Recommendation

Remove the chevrons within the buttons.

[josephrlee]

This looks like a pretty simple fix, I'm guessing it's a 1 pointer. Code to edit is here.

I think we just need to remove the iconLeft and iconRight lines.

      <ButtonGroup
        buttons={[
          {
            label: 'Cancel',
            onClick: onCancel,
            secondary: true,
            iconLeft: '«',
          },
          {
            label: 'Update',
            onClick: onUpdate,
            iconRight: '»',
          },
        ]}
      />

[mgleo]

Private Zenhub Image

[OptionSelect]

I have deleted the lines but am having trouble testing. Still working on this to prove fix worked.

[HeatherRienks]

@OptionSelect - any updates to share on this one?