department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

FE | Profile | Contact information | Cancel confirmation doesn't display after address validation flow #64452

Open andaleliz opened 1 year ago

andaleliz commented 1 year ago

Background

In the contact information section of profile, the "Are you sure" confirmation modal doesn't appear if you trigger address validation, go back to editing, and then cancel.

Steps to reproduce

Address validation flow with suggestion

  1. Go to the contact info section of profile with any staging user.
  2. Click edit for either address. Make a note of the address that is in there.
  3. Enter the address 1074 Sweetflower Dr, Hoffman Estates, IL 60194. This will trigger the address validation with a suggested address
  4. Select Go back to editing. Notice the originally saved address still has unsaved edits.
  5. Select Cancel

Cancel should trigger this confirmation modal, but it doesn't.

Address validation flow without suggestion

  1. Go to the contact info section of profile with any staging user.
  2. Click edit for either address. Make a note of the address that is in there.
  3. Enter the address 3101 B Fort Valley Rd Flagstaff, AZ 86001. This will trigger the address validation without a suggested address
  4. Select Go back to editing. Notice the originally saved address still has unsaved edits.
  5. Select Cancel

Address validation flow for missing unit number

  1. Go to the contact info section of profile with any staging user.
  2. Click edit for either address. Make a note of the address that is in there.
  3. Enter the address 600 S Michigan Ave, Chicago, IL 60610. This will trigger the address validation for missing unit number
  4. Select Go back to editing. Notice the originally saved address still has unsaved edits.
  5. Select Cancel

Cancel should trigger the confirmation modal for each use case, but it doesn't.

Tasks

AC

mtcA6 commented 2 months ago

notes on pointing - 3-5 leaning towards a 5 because this would involve working with/around that main address component (ProfileInformationFieldController) which is used by a LOT of other applications.

ACParker89 commented 1 month ago

@ACParker89 - rollover

ACParker89 commented 1 month ago

@ACParker89 - move to on hold and work to recreate the AC to decide if still needed

ACParker89 commented 6 days ago

@a6marinos we can try to recreate this and then determine if its needed