department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Design Intent - IA Feedback - Appointments FE Team, Appointments on VA.gov, Appointment Details Redesign #65838

Open erinrwhite opened 11 months ago

erinrwhite commented 11 months ago

VFS actions

Thoughts/questions

Feedback

Practice areas will document their feedback on the VFS-provided artifacts following the Must, Should, and Consider Framework. Platform reviewers may also provide additional notes that don’t comment on the artifacts themselves but are important for implementation (eg. engineering/coding notes).

outerpress commented 3 months ago

@Cieramaddox could you review this one?

Cieramaddox commented 3 months ago

@erinrwhite Is this a launch blocker, or could I get a ticket out to fix this post launch?

erinrwhite commented 3 months ago

@Cieramaddox none of these would be launch-blocking - and because this is feedback from a Design Intent in September it might no longer be valid.

outerpress commented 1 month ago

@erinrwhite just wanted to check up on this one since it didn't come up during staging review. Is it still a must to visually separate the action buttons? It looks like they're still on the same line.

And if so (I'm assuming yes) does visually separate means they should be on separate lines - or are there other treatments that you were thinking of?

Screenshot 2024-07-19 at 2.16.54 PM.png
outerpress commented 1 month ago

@erinrwhite I think we resolved all the content inconsistencies, and no more came up on staging review so I'm checking off that item.

erinrwhite commented 1 month ago

Thanks @outerpress for following up on this one! It isn't an experience standards violation so much as a suggestion to have these actions farther apart from each other. A separate line would be great! But again, because this isn't a standards violation, you can take or leave this feedback (this note should have originally been a "should", not a "must").

outerpress commented 1 month ago

Thank you @erinrwhite ! @Cieramaddox any thoughts on/objections to moving these to separate lines? If you prefer we can also leave it as is since there's been some talk about repositioning these buttons entirely in the future.

outerpress commented 1 month ago

@outerpress NTS this may be done, look for a dev ticket for this

outerpress commented 1 month ago

Going to handle this in #88859