department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Claimant Personal Information #66104

Closed holdenhinkle closed 2 weeks ago

holdenhinkle commented 11 months ago

Issue Description

The Claimant Personal Information page will be available to:

  1. Non-Veteran users ONLY
  2. Authenticated users and unauthenticated users
  3. 21-22 and 21-22a forms.

Content is dynamic based on:

  1. If the user selects a VSO for representation, they will see "VA Form 21-22" at the top of the page. If the user selects an attorney/claims agent for representation, they will see "VA Form 21-22a" at the top of the page.
  2. Authenticated users.
    ~1. If the auth user has all of the required information (first name, last name, date of birth) in their profile show the authenticated design~ (Saving this for https://github.com/department-of-veterans-affairs/va.gov-team/issues/90986)
    1. If the auth user has some of the required information, show the unauthenticated design and prefill any text inputs when possible
    2. If the auth user has none of the required information, show the unauthenticated design with empty text inputs
  3. If the user is unauthenticated, show the unauthenticated design with empty text inputs

The information collected on this page will be routed to the forms as follows:

URL: /claimant-personal-information

Previous paths:

  1. /claimant-relationship

Next paths:

  1. ~/claimant-contact (non-Veteran auth with all required info on file)~ (Saving this for https://github.com/department-of-veterans-affairs/va.gov-team/issues/90986)
  2. /claimant-contact-phone-email (all other non-Veteran users)

MVP Planning Mural

"Auth" Designs (Prefill)

Prototype, Canvas, Annotations

Disclaimer: We only designed the authenticated experience for a Veteran user. In a case where we have a non-Veteran claimant that sees this authenticated experience, we'd only need to display the first name, last name and date of birth. SSN, Branch of Service and VA File Number are not required in the Claimant section of the 21-22 and 21-22a.

Screenshots image.png image.png

"Unauth" Designs (Input fields)

Prototype, Canvas

Screenshots image.png image.png

Tasks

Acceptance Criteria

cosu419 commented 1 month ago

Can't really test the auth state without prefill configured on vets-api - @mtri can you check the unauth state?

mtri commented 1 month ago

Unauth state looks good.

oddball-lindsay commented 1 month ago

Awaiting the ability to pre-fill when possible

cosu419 commented 4 weeks ago

8/8 update: part of an active PR with CI checks that need to be addressed. Also pending the prefill functionality vets-api ticket.

cosu419 commented 3 weeks ago

8/12 update: CI checks passing, PR pending review

cosu419 commented 3 weeks ago

Looking into the prefill response - expecting the auth state to be triggered for users with profile information available.

cosu419 commented 2 weeks ago

Rendering the auth state is wrapped up in the same issue as Claimant Contact Information. Need to figure out why formData.veteran is empty for test users.

oddball-lindsay commented 2 weeks ago

I ran out of time today -- to do for me: create a similar ticket that focuses on the prefill pattern and carry over Colin's notes above. Then link that ticket here for continuity and close this ticket out.

Assigning myself as a reminder to come back to this ticket :).

oddball-lindsay commented 2 weeks ago

Here's the ticket for the prefill pattern, which will be in Product Backlog for a future time https://github.com/department-of-veterans-affairs/va.gov-team/issues/90986.