department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

Chapter 2: Implement the 'enter' view (as opposed to the 'edit') for the Veteran Contact Information Page [Authenticated Users] #66157

Closed holdenhinkle closed 1 year ago

holdenhinkle commented 1 year ago

Issue Description

The MVP requires a ' Veteran Contact Information' page. There will be two states in this step for Authenticated users:

  1. User can see the information on file, with an option to click Edit
  2. User can edit the information on file, with an option to Enter which will save any changes

This issue is to tackle the 2nd state -- the 1st state is handled in #66103.

While we don't have designs yet for this 2nd, Enter state, you can view the designs for the 1st Edit state here for context.


Tasks

Acceptance Criteria

oddball-lindsay commented 1 year ago

@holdenhinkle share what you have with me here and I'm happy to check that against designs! 😊

holdenhinkle commented 1 year ago

Weird - is there a duplicate? This is the one I was working off of - https://app.zenhub.com/workspaces/accredited-representation-management-team-64d0dc51d3e8f4788ac6ef96/issues/gh/department-of-veterans-affairs/va.gov-team/66102

oddball-lindsay commented 1 year ago

that's my bad! i misunderstood which page you wanted to review and left this comment before you shared materials over in slack.

holdenhinkle commented 1 year ago

Done!

holdenhinkle commented 1 year ago

PR - https://github.com/department-of-veterans-affairs/vets-website/pull/26216