DR | Set up continuous deployment for appeals forms

[Mottie]

Value Statement

As a developer I want to set up continuous deployment (CD) So that we can speed up our iterative process for implementing changes & fixes

Background Context

With the VA adding more apps and increasing test coverage, the continuous integration (CI) time will increase. More flaky test will likely be exposed and cause delays. With a switch to continuous deployment, our apps will be isolated and only need to run tests associated with the app. Release to production is also performed. We won't need to wait for the daily deploy cycle.

Pros:

• Quicker CI
• Can opt-out of CD if we want
• Don't have to wait for deployment schedule
• Delivery won't be limited by flaky tests from other apps

Cons:

• Does NOT cover backend code
• Bugs will be deployed and effect Veterans in production almost instantly after merging in a code change (BUT, again, we can opt-out of CD if we want)
• Feature flags will need to be used for any significant changes

Designs and Build Notes

• Add here

Out of scope

• Add here

Open questions

• Add here

Tasks

• [x] Review continuous deployment set up instructions
• [x] Check for app isolation

  {
    "appeals": {
      "appsThatThisAppImportsFrom": {
        "static-pages": {
          "filesImported": [
            {
              "importer": "src/applications/appeals/996/wizard/WizardContainer.jsx",
              "importee": "src/applications/static-pages/wizard"
            }
          ]
        }
      },
      "appsThatImportFromThisApp": {},
      "platformFilesThatImportFromThisApp": [
        "src/platform/forms/tests/sub-task/basic-2-page.unit.spec.jsx"
      ]
    }
  }

• [x] HLR: Switch deprecated wizard to subtask (fixes app isolation - see pull #29089)
• [x] SC: Copy subtask pages into platform test (fixes app isolation - see pull #29040)
• [ ] Add appeals to allow list
• [ ] Educate team members on the impact of this change
• [ ] Connect with Eugene on disconnecting continuous deployment
• [ ] Test minor change in CD cycle
• [ ] Notify stakeholders about this change

Acceptance Criteria

• [ ] Automatic deployment works as expected

Definition of Ready

• [ ] HLR subtask work complete
• [ ] Copy subtask pages into platform
• [ ] Running yarn check-app-imports --app-folders appeals shows that our apps are isolated

Definition of Done

• [ ] Continuous deployment in place
• [ ] Continuous deployment tested satisfactorily
• [ ] All team members are aware of the impact of these changes
• [ ] Implementation has been shared with all team members & stakeholders

[saderagsdale]

@kylesoskin @data-doge need some input on how we know when this work is ready to pick up and what the exact tasks are, including any gate checks with stakeholders or the platform team.

[saderagsdale]

Need to confirm if this is properly groomed before committing.

[saderagsdale]

Questions:

• Is the pipeline already setup correctly for our app? Any configurations needed?
• Is version control setup?
• What E2E, unit, and integration tests do we need?
• Do we need a build script and deployment script for automation?
• How is this connected to monitoring?
• What is the rollback procedure?
• What documentation is needed?
• Do we need to define security and access control or is this predefined by platform?
• Are there any regulatory requirements from OCTO?

[saderagsdale]

Need to take care of things first, including:

• All apps being isolated (HLR is not)

[saderagsdale]

@Mottie can we close this?

[Mottie]

Not yet, let's discuss with Shaun

[shaunburdick]

Hold on this ticket until the HLR and SC form updates have been release.

[shaunburdick]

Once preview environment is in place, we can test everything in the PR and we wouldn't need this ticket.