department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
284 stars 206 forks source link

Review exported PDFs from "MHV Rx" team #66799

Closed vmenshutin-bylight closed 1 year ago

vmenshutin-bylight commented 1 year ago

What does your team need support for? Check all that apply.

The "MHV Rx" team is making a new PDF template for Medications List and Medication Details pages. We need to review these samples to make sure the a11y requirements are being met as development proceeds.

Will this new product be released incrementally (for instance 25% of users initially)?

Supporting artifacts

Please provide supporting artifacts as available.

There are sample PDFs:

Non-VA-medications-details-Harry-Potter-10-03-2023_120911p.m..pdf VA-medications-details-Harry-Potter-10-03-2023_120856p.m..pdf VA-medications-list-Harry-Potter-10-03-2023_120617p.m..pdf

Will this work be going through the Collaboration Cycle?

When does this work need to be done?

Do you plan to bring this to an upcoming content office hours session?

Note: If we think this work would benefit from a collaborative session with you, we may ask you to bring it to office hours or set up a separate time to meet.

About your team

SarahKay8 commented 1 year ago

💻🅰️Testing device: Acrobat Adobe

📄PDF review - Calamine lotion (First Doc)

Non-VA-medications-details-Harry-Potter-10-03-2023_120911p.m..pdf

📄PDF Review - Lactated Ringers (Second Doc)

VA-medications-details-Harry-Potter-10-03-2023_120856p.m..pdf

📄PDF Review Medications - Lactated Ringers (Third Doc)

VA-medications-list-Harry-Potter-10-03-2023_120617p.m..pdf

Allergies section

Overall Feedback on all PDF(s)

Header/Footer Issue to be aware of

Header/Footer feedback from Evan B. "It would be best to find a way to make sure header/footer content isn't read at all. If this is content is important and should be read, only one instance of the header/footer should be accessed - the header on the the first page and the footer on the last page. This is the ideal scenario. It seems like the app is trying to make the header/footer content hidden from users due to the tags, but it's still picked up. Since they come at the end of the document, it doesn't impact the user much, so I'd be okay leaving as is if there's no way to address the issue."

cc: @vmenshutin-bylight @BobbyBaileyRB @artsymartha68

If there is any thing I missed or if I need to clarify anything, lmk

acrollet commented 1 year ago

Regarding tab order, we're waiting on a patch to get merged to the upstream package: https://github.com/foliojs/pdfkit/pull/1449

SarahKay8 commented 1 year ago

@acrollet Closing as a Jira Ticket has been created. Slack thread here