[FE] My VA: Remove My VA from unauth header

[ajakabcin]

Background

The original purpose of having "My VA" in the unauth header on VA.gov was to let users know that there is personalized content once they log in. But now that we reroute from the homepage to My VA at login, we don't need it, so we're going to remove "My VA" from the unauth header (as seen below):

Slack thread with sitewide

Information about the injected header

Tasks

• [x] Remove "My VA" from the unauth header using a feature flag to hide it
• [x] Request code review from a dev on the sitewide team (#sitewide-public-websites slack)
• [x] Update tests
• [x] Move to validate and let PM know

Acceptance Criteria

When a user is authenticated

• [ ] My VA link is in the header no matter what state the feature flag is set to

When the user is unauthenticated

• [ ] My VA link isn't in the header if the feature flag my_va_show_header_link is false (Off)
• [ ] My VA link is in the header if the feature flag my_va_show_header_link is true (On)

Validation

• Who can validate this ticket? (FE, BE, Design, PM)? Any team member
• How can this work be validated?
  1. Go to staging.va.gov
  2. See that "My VA" does not appear in the unauthenticated header
  3. Log in with any staging user
  4. Confirm that My VA still appears in the header after signing in

[dellerbie]

@ajakabcin @Samara-Strauss This is on staging now. Here is the feature flag, my_va_show_header_link, on staging:

https://staging-api.va.gov/flipper/features/my_va_show_header_link

By default, we won't show the My VA link, so we just need to enable this flag if we want to show it again.

[Samara-Strauss]

Looks like there are some bugs with this issue. The unauthenticated nav looks fine, but when I log into staging, this is what I am seeing:

The authenticated nav should look like this (this is production currently):

To be clear:

1. My VA was supposed to be removed from the unauthenticated state only.
2. My VA should still appear in the authenticated nav, and the My VA and My HealtheVet links should still be right-aligned.

[ajakabcin]

@dellerbie I moved this back in progress while you de-bug thanks!

[ajakabcin]

Confirmed My VA appears in the auth header (user 192):

Confirmed My VA does not appear in the unauth header:

[ajakabcin]

Turned the flag off in production which removes My VA from the unauth header.

And with the fix that went out this week, confirmed My VA still appears in the auth header in production.

[Samara-Strauss]

YAY! So excited to see this. I've validated this in production. We should be good to close.