department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

Review and approve launch of the exported PDFs from "MHV Rx" team #67990

Closed vmenshutin-bylight closed 1 year ago

vmenshutin-bylight commented 1 year ago

What do you need support with?

Please review the following PDFs and approve launching with them.

These PDFs have been reviewed within https://github.com/department-of-veterans-affairs/va.gov-team/issues/66799.

The following issues have been fixed:

More information could be found in the comments section here: https://jira.devops.va.gov/browse/MHV-50186

Other issues require major investigation and enhancements, which would influence both medical records and medications teams. These issues are sought to be addressed after the launch.

When do you need this support by?

ASAP

How urgent is this request?

Very urgent, this is blocking other critical work and is needed ASAP

Supporting artifacts (if any)

Non-VA-medications-details-Harry-Potter-10-19-2023_21829pm.pdf VA-medications-details-Harry-Potter-10-19-2023_21618pm.pdf VA-medications-list-Harry-Potter-10-19-2023_22252pm.pdf

Who's on your team?

Team name: vfs-mhv-medications product owner: Raquel Robertson Product manager: Tanner Bird Designer: @coultonbunney-usds FE engineer: @acrollet @vmenshutin-bylight Product/team Slack channel: #[mhv-medications-rx]

Do you have an accessibility champion on your team?

No, we don't have a champion (yet)

If you have an accessibility champion, what's their name?

No response

Is anyone on your team interested in becoming an accessibility champion?

No response

SarahKay8 commented 1 year ago

@vmenshutin-bylight Everything else is good. However, because I can't see the conversation that's happening in JIRA, could you summarize why these list(s) are still in paragraph tags?

91B1E670-F8C4-4CB8-AA46-3DE70646AB98

SarahKay8 commented 1 year ago

When a visual list isn't tagged as a list and is instead placed within a paragraph tag in a PDF, it has a lot of negative effects on AT users, especially those who rely on screen readers.

VO + Jaws uses tags and structure within a document to provide a meaningful reading order. When a list isnt tagged as such and is placed in a paragraph tag, it loses its structural significance. Screen readers won't recognize it as a list, making it v difficult for users to understand that the content is part of a list.

Also - When lists are not correctly tagged, it disrupts the logical flow of the document and makes it harder for users to navigate efficiently.

Video for reference (sound on)

https://github.com/department-of-veterans-affairs/va.gov-team/assets/102324990/5657d505-d34c-4889-8b04-480eadf9d7d6

I wouldn't consider this launch blocking, but it is a huge a11y concern @vmenshutin-bylight

SarahKay8 commented 1 year ago

cc: @acrollet

acrollet commented 1 year ago

@vmenshutin-bylight fwiw I do see that list markup is supported by pdfkit

klawyer commented 1 year ago

Thanks @SarahKay8! I am the OCTO Product lead on this effort.

Decision: Our first launch is only to a few users (Phase 0), so we are going to move forward with that launch with this as-is. But, this will be fixed before we expand to a larger set of users (Phase 1).

SarahKay8 commented 1 year ago

Thanks @klawyer! assuming good to close?

SarahKay8 commented 1 year ago

When a visual list isn't tagged as a list and is instead placed within a paragraph tag in a PDF, it has a lot of negative effects on AT users, especially those who rely on screen readers.

VO + Jaws uses tags and structure within a document to provide a meaningful reading order. When a list isnt tagged as such and is placed in a paragraph tag, it loses its structural significance. Screen readers won't recognize it as a list, making it v difficult for users to understand that the content is part of a list.

Also - When lists are not correctly tagged, it disrupts the logical flow of the document and makes it harder for users to navigate efficiently.

Video for reference (sound on)

20231020140952229.mp4 I wouldn't consider this launch blocking, but it is a huge a11y concern @vmenshutin-bylight

Added a video for reference just in case @klawyer @acrollet