search

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

Collaboration Cycle for Benefits and Claims - Dependent Experience Team, Dependency Claims, VA Form 21-686C Military Base Outside the U.S. Address Issues #68019

Open ajialeilani opened 1 year ago

ajialeilani commented 1 year ago

VFS product information

VFS team name

Benefits and Claims - Dependent Experience Team

Product name

Dependency Claims (686/674)

Feature name

VA Form 21-686C Military Base Outside the U.S. Address Issues

GitHub label for product

dependents

GitHub label for feature

No response

Public DSVA Slack channel for VFS team

benefits-dependents-management

Kickoff questions

Toggle kickoff questions ### When did/will you start working on this product/feature? 9/2023 ### Will your work result in visible changes to the user experience? Yes ### Are you doing research with VA.gov users? No ### Will your work involve changes to... Tools, applications and dynamic pages ### Does your product/feature have Google Analytics tracking and a KPI dashboard in Domo? Yes ### Do you need to capture any additional analytics or metrics? Unsure ### Product outline https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/products/dependents/21-686C-military-base-outside-the-US-address-issues/initiative-brief.md ### Verify all relevant materials provided to Governance Team - [X] I have provided all relevant and up-to-date links, screenshots, images, designs, etc. of the as-is version of the product ### Notify the Collaboration Cycle team of this ticket in your team's public Slack channel. - [X] I acknowledge that I must notify the Governance team by completing the collab cycle kicckoff workflow in my team's Slack channel after submitting this issue. This can be completed by typing "/collab cycle" and selecting the appropriate workflow. - Kickoff Slack Thread with VFS team: [Kickoff thread](https://dsva.slack.com/archives/C0547Q0K0LF/p1697749772939659)

Recommended Collaboration Cycle touchpoints

Design Intent

Toggle Design Intent #### Before meeting ##### VFS actions - [ ] Review [Design Intent Guidance](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/design-intent) to understand what this touchpoint involves. - [ ] Schedule your Design Intent (with at least 2 business days lead time from now): - Open the [Calendly design intent calendar](https://calendly.com/collaboration-cycle/design-intent-or-midpoint-review) - Select a date and time and click "Confirm" - Add your name and email - Click "Add Guests" and enter the email addresses for VFS team attendees - Click "Schedule Event" - [ ] Link all artifacts in the `Design Intent artifacts for review` section below at least two business days before the scheduled Design Intent. Please don't add artifacts in the comments section. **Design Intent artifacts** See Platform guidance on [Design Intent artifacts](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/design-intent#Designintent-Artifacts). Platform feedback is based solely on the artifacts provided, as reviewed during the two days before the Design Intent meeting. Any work not included in the artifacts below or any ongoing work taking place during the review period may not be reflected in that feedback. - [x] [User flow (required)](https://app.mural.co/t/coforma8350/m/coforma8350/1693342568662/de8a4eb202d07e4802e1be45fe7f6a8f5d02128e?sender=u25797e1e73ca47c67e3c4331) (Specifically [Step 2 of 5 Veteran's Info](https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/products/dependents/21-686C-military-base-outside-the-US-address-issues/Step%202%20of%205%20Veterans%20Info.png)) - [x] [Whiteboard sketch or other lo-fi prototypes or wireframes](https://github.com/department-of-veterans-affairs/va.gov-team/tree/master/products/dependents/21-686C-military-base-outside-the-US-address-issues/after-screenshots) - [ ] Research plan - [x] Any other artifacts you have so far - [Initial proposed solution](https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/products/dependents/21-686C-military-base-outside-the-US-address-issues/686c%20address%20issues%20before.png) from [Dependents Scratchpad](https://app.mural.co/t/departmentofveteransaffairs9999/m/departmentofveteransaffairs9999/1690311086208/96d5f59b299912bc8c69542e6943d5b2213b9c72?sender=u25797e1e73ca47c67e3c4331) - [Initial Zenhub Task](https://github.com/department-of-veterans-affairs/va.gov-team/issues/63545) - [Current Zenhub Task - High-priority short-term solution to null claims](https://github.com/department-of-veterans-affairs/va.gov-team/issues/63124) - [Related research](https://github.com/department-of-veterans-affairs/va.gov-team/issues/61193) - [CAIA Ticket](https://github.com/department-of-veterans-affairs/va.gov-team/issues/65553) ##### Platform actions - [ ] Slack thread with VFS team: https://dsva.slack.com/archives/C0547Q0K0LF/p1698074800493949 - [ ] Meeting date/time: Friday 10/27 2023 at 11.30 AM ET #### After meeting ##### Platform actions * Accessibility * [x] Feedback ticket attached * [ ] No feedback * Design * [x] Feedback ticket attached * [ ] No feedback * IA * [x] Feedback ticket attached * [ ] No feedback * [x] Update this ticket with the Zoom recording - [Recording link](https://oddball-io.zoom.us/rec/share/j7wvYoIm0Z9H4vaZz0Obo_DvFc_oYjkpAQAebiogTfIcQBwYmtaMQN6zetB_w1y9.H2r2gRfCyM_4jjju) - Passcode: 1^XyLk0^ ##### VFS actions - [ ] Review feedback tickets and comment on the ticket if there are any questions or concerns

Sitewide CAIA Intake Request

Toggle Sitewide CAIA Intake Request ##### VFS actions - [x] Complete the [Sitewide CAIA intake request process](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/Sitewide-CAIA-intake-request.2124906551.html) - [x] Link to the Sitewide CAIA Intake Request ticket below - [ ] [CAIA Ticket](https://github.com/department-of-veterans-affairs/va.gov-team/issues/65553)

Midpoint Review

Toggle Midpoint Review #### Before meeting ##### VFS actions Navigate to reference link: [Midpoint Review Guidance](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/midpoint-review) - [ ] Schedule your Midpoint Review when ready: - Open the [Calendly midpoint review calendar](https://calendly.com/collaboration-cycle/design-intent-or-midpoint-review) - Select a date and time and click “Confirm” - Add your name and email - Click "Add Guests" and enter the VFS meeting attendees email addresses - Invite all relevant VFS team members, including accessibility support, product owners, and other VA stakeholders - Click "Schedule Event" - [ ] Check this box if you'd like this review to be asynchronous (Please refer to the [Midpoint Review guidance](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/Midpoint-review.1781039167.html) for the difference between a synchronous meeting and an asynchronous review) - [ ] Link all artifacts **ONLY** in the Midpoint Review artifacts section below at least two days before the scheduled Midpoint Review. **Do NOT add artifacts to Comments section** **Midpoint Review artifacts** See Platform guidance on [Midpoint Review artifacts](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/midpoint-review#Midpointreview-Artifacts). Platform feedback is based solely on the artifacts provided, as reviewed during the two days before the Midpoint Review meeting. Any work not included in the artifacts below or any ongoing work taking place during the review period may not be reflected in that feedback. Provide links or documents for the following: - [x] [Finalized design prototype or mockup](https://www.sketch.com/s/870d13d5-a465-48a3-acc2-32682ba8f780) - [x] No changes to original designs, but I've included original language options for the checkbox and expander if the changes to recently-validated checkbox language are a concern on - PROPOSED / solution 3 mailing address unselected original checkbox language and - PROPOSED / solution 3 mailing address unselected additional info expanded original language - [x] [Launch plan](https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/products/dependents/21-686C-military-base-outside-the-US-address-issues/launch-plan.md) - [ ] Conversation guide **Content artifacts** - [x] Please include a link to any [Sitewide CAIA](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/sitewide-content-and-ia-intake-request) feedback you received, including a content source of truth, any relevant static content page and entry point updates, and the intake form. **IA artifacts** - [x] Please include a link to any [Sitewide CAIA](https://github.com/department-of-veterans-affairs/va.gov-team/issues/65553) feedback you received, including an IA review document or intake form. ##### Platform actions - [x] [Slack thread with VFS team](https://dsva.slack.com/archives/C0547Q0K0LF/p1698847807003759) - [x] Meeting date/time: November 3 at 11:30pm ET #### After meeting ##### Platform actions * Accessibility * [ ] Feedback ticket attached * [x] No feedback * Content * [ ] Feedback ticket attached * [ ] No feedback * Design * [x] Feedback ticket attached * [ ] No feedback * IA * [x] Feedback ticket attached * [ ] No feedback * [x] Update this ticket with the Zoom recording - [Recording link](https://oddball-io.zoom.us/rec/share/oMDpGDyLzxH0IADqBFzEp6beHuOJR7D3l5zHl4O3wvRlSa5WNuxvs5BmTcBZhfdH.rf2m9YNcHX9s-ckY) - Passcode: `GRx*%=*1` ##### VFS actions - [ ] Review feedback tickets and comment on the ticket if there are any questions or concerns

Analytics Request

Toggle Analytics Request #### VFS actions - [ ] Complete the [analytics request process](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/Analytics-request.1782120453.html) - [ ] Link to the Analytics Implementation and QA Request ticket below

Contact Center Review

Toggle Contact Center Review #### VFS actions - [ ] Complete the [Contact Center review process](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/Contact-center-review.1782317061.html) - [ ] Link to the Contact Center review request ticket below

Staging Review

Toggle Staging Review #### Before meeting ##### VFS actions - Navigate to reference link: [Staging Review Guidance](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/staging-review) - [ ] Schedule your Staging Review when ready: - Open the [Calendly staging review calendar](https://calendly.com/collaboration-cycle/staging-review) - Select a date and time and click “Confirm” - Add your name and email - Click "Add Guests" and enter the VFS meeting attendees email addresses - Invite all relevant VFS team members, including accessibility support, product owners, and other VA stakeholders - Click "Schedule Event" - [ ] If this product contains any [experimental design](https://design.va.gov/experimental-design/), add the `experimental-design` label and schedule a meeting with DSC to present the research findings. - [ ] Link all artifacts **ONLY** in the Staging Review artifacts section below at least four days before the scheduled Staging Review. **Do NOT add artifacts to Comments section** - [ ] I confirm the environment is available and test users have been provided. - [ ] Please verify your product information in the [Product Directory](https://depo-platform-documentation.scrollhelp.site/getting-started/vfs-product-directory). **Staging Review artifacts** See Platform guidance on [Staging Review artifacts](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/Staging-review.1810137181.html#Stagingreview-Artifacts). Platform findings are based solely on the staging URL and test users provided, as reviewed during the four days before the Staging Review meeting. Any test cases not covered or any ongoing work taking place during the review period may not be reflected in those findings. **Product artifacts** - [x] [Staging Site](http://904ed4ee963830d6231e36fec33140a9.review.vetsgov-internal/), [address component](http://904ed4ee963830d6231e36fec33140a9.review.vetsgov-internal/view-change-dependents/?next=loginModal) - [x] Staging test user information: - email: vets.gov.user+232@gmail.com - See password in [Launch Plan Credentials](https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/products/dependents/21-686C-military-base-outside-the-US-address-issues/launch-plan-credentials.md) document - When logging in - Use Id.me - Make sure the url at the top is switched to oauth=false. If it's true, swap it and refresh. - [x] Specify which pages are included in the review - [21-686](http://904ed4ee963830d6231e36fec33140a9.review.vetsgov-internal/) > [Step 2 of 5: Veteran's Information](http://904ed4ee963830d6231e36fec33140a9.review.vetsgov-internal/view-change-dependents/?next=loginModal) **Note:** Please double-check that you've provided staging access information appropriate for testing the tool or feature. Don't put staging credentials in your va.gov-team ticket; store [test user information, passwords, and tasks](https://github.com/department-of-veterans-affairs/va.gov-team-sensitive/blob/master/Administrative/vagov-users/staging-test-accounts-accessible-example.md) in a .md file in the va.gov-team-sensitive repository. **Content artifacts** - [x] Please include a link to any [Sitewide CAIA](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/sitewide-content-and-ia-intake-request) feedback you received, including a content source of truth, any relevant static content page and entry point updates, and the intake form. - [CAIA Intake Ticket](https://github.com/department-of-veterans-affairs/va.gov-team/issues/65553) - [Sketch file](https://www.sketch.com/s/870d13d5-a465-48a3-acc2-32682ba8f780/p/AFA43D59-B983-46B6-9702-F37DDB5ABF6D/canvas#Comment) **IA artifacts** - [ ] Please include a link to any [Sitewide CAIA](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/sitewide-caia-intake-request) feedback you received, including an IA review document or intake form. **QA artifacts** An artifact that corresponds to each standard in the [QA Standards](https://depo-platform-documentation.scrollhelp.site/developer-docs/quality-assurance-standards). - [x] [Regression test plan](https://dsvavsp.testrail.io/index.php?/plans/view/5034) - [x] [Test plan](https://dsvavsp.testrail.io/index.php?/plans/view/5036) - [x] [Coverage for References](https://dsvavsp.testrail.io/index.php?/reports/view/586) - [x] [Summary(Defects) reports](https://dsvavsp.testrail.io/index.php?/reports/view/587) - [x] [E2E tests](https://github.com/department-of-veterans-affairs/vets-website/pull/26200/files) - [ ] [Code coverage](https://depo-platform-documentation.scrollhelp.site/developer-docs/quality-assurance-standards#QAstandards-unit-test-coverageUnitTestCoverage) (src/applications/disability-benefits/686c-674/config/address-schema.js in the PR diff) **Accessibility artifacts** _Changes made are minor (e.g. new error messaging and validation) and use existing design system styles._ - [ ] [Completed accessibility testing artifact](https://github.com/department-of-veterans-affairs/va.gov-team/issues/new?assignees=briandeconinck&labels=a11y-testing&template=a11y-testing.yaml&title=Accessibility+Testing+for+%5BTeam+Name%2C+Product+Name%2C+Feature+Name%5D). For details, see [Prepare for an accessibility staging review](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/prepare-for-an-accessibility-staging-review). ##### Platform actions - [x] [Slack thread with VFS team](https://dsva.slack.com/archives/C0547Q0K0LF/p1699478145221019) - [x] Meeting date/time: ~Thursday, November 16, 2023 at 1:30PM ET~ Rescheduled: November 30 at 3:30pm ET #### After meeting ##### Platform actions - [x] Update this ticket with the Zoom recording - [Recording link](https://oddball-io.zoom.us/rec/share/m5sItktKaoGvFIVL7bqI1dDwX3VwkVikqbzPxuTHrpzf-Ff-Xq3wd6CV0ZTtuV9l.8b086nwYifIAolxa) - Password: `2Jd+Rgtj` ##### VFS actions - [ ] Review the findings tickets and comment on the ticket if there are any questions or concerns - [ ] Close individual findings tickets when the issue has been resolved or validated by your Product Owner. If a team has additional questions or needs Platform help validating the issue, please comment on the issue ticket. - [ ] After launch, [request an accessibility audit from the VA 508 Office](https://depo-platform-documentation.scrollhelp.site/developer-docs/request-support-from-the-va-508-office#RequestsupportfromtheVA508office-AuditRequest). This is required even if no accessibility issues were found during the Staging Review. - [ ] Share ServiceNow ticket number here: ______ - [ ] Close ticket once Privacy, Security, Infrastructure Readiness Review has been completed, VA 508 Office audit is requested, and all other post-Staging actions are complete

Privacy, Security, Infrastructure Readiness Review

Toggle Privacy, Security, Infrastructure Readiness Review #### VFS actions - [ ] Complete the [Privacy, security, infrastructure readiness review process](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/Privacy-and-security-review.1782317101.html) - [ ] Link to the Readiness Review ticket below #### Platform actions - [ ] Privacy, security, infrastructure readiness review is complete
ajialeilani commented 1 year ago

@erinrwhite should we hold off on merging any changes until this is complete? We were hoping to implement this temporary fix to null dependent claims asap

erinrwhite commented 1 year ago

@ajialeilani thank you for asking about this. Tagging in @shiragoodman.

shiragoodman commented 1 year ago

@ajialeilani This change hasn't gone through a Collaboration Cycle Staging Review yet which is required. You are not permitted to launch on VA.gov until this takes place.

ajialeilani commented 1 year ago

Thank you @shiragoodman. @evansmith looks like we need to hold off

evansmith commented 1 year ago

@ajialeilani sounds good! let me know if I can assist in any way with the staging review.