Closed jenstrickland closed 4 years ago
Hey @jenstrickland, is this the extent of the feedback for the Design Intent collaboration? If so, I'd like to groom it with the team and create any additional tickets to track knocking this out.
@MickinSahni This is the extent of the accessibility feedback for the design intent collaboration, given the project timeline. There would normally be additional tickets with feedback for the other practice areas, but they had none and used a comment.
@MickinSahni I just remembered this download link documentation that may be of use, if your team has download links. @1Copenut and I collaborated on defining the accessible download links, and iirc this is going to eventually be in the design system.
@ncksllvn doublecheck that the should and consider items are not already taken care of. if not, groom and prep for prioritization (estimate, milestone, etc.)
Going through this list, noting the ones we need to revisit. Going to follow up against boiling this down further.
I think we're good here
We should implement these as part of #11453 or after.
These items we need to clarify and decide on before we can move forward with technically.
Form last updated: 03-22-2020
. Should this be Form last updated: 03/22/2020
, or Form last updated: March 22, 2020
?@MickinSahni @jenniferlee-dsva I just circled back to this. Many of these I think we can do in our upcoming work for adding the additional fields into the search results in https://github.com/department-of-veterans-affairs/va.gov-team/issues/11453, but others we need to discuss a bit before implementation
Accounted for in #11453. Archiving this to keep for our records.
VSP and VSA accessibility feedback
Feedback framework
VSP design accessibility feedback
❗️ Must --> https://github.com/department-of-veterans-affairs/va.gov-team/issues/7097
Manage focus when users press Search. Ideally we would move focus to the "Showing results for
SEARCH TERM
"It will be too much information read back if we use
aria-live
regionFocus will need to be managed when we have pagination too. Probably set focus back to the same spot ("Showing results for
SEARCH TERM
") when user presses a pagination link."Apply online" button will need an aria-label or SR-only text to be clear to screen readers. For instance:
⚠️ Should
aria-hidden="true"
attribute applied. These are stops for screen readers and generate cognitive noise.< Home
✔️ Consider
Definitions of Done
No additional review needed.
VSA design accessibility feedback
❗️ Must
<table>
- using responsive techniques (this new responsive table sample that may be of interest: https://codepen.io/aardrian/pen/VwYyVJY)<ol
> if the results will be weighted as indicated during our meeting<dl>
structure, where the list is one entire description list, and each item is a<dt>
with relevant<dd>
info beneath it.⚠️ Should
✔️ Consider
prefers-reduced-motion
as a progressive enhancement.👍 / 👎 Definitions of Done