department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 202 forks source link

Accessibility feedback for Design intent Collaboration [VA form search page] #6825

Closed jenstrickland closed 4 years ago

jenstrickland commented 4 years ago

VSP and VSA accessibility feedback

Feedback framework


VSP design accessibility feedback

❗️ Must --> https://github.com/department-of-veterans-affairs/va.gov-team/issues/7097

⚠️ Should

✔️ Consider


Definitions of Done

No additional review needed.


VSA design accessibility feedback

❗️ Must

⚠️ Should

✔️ Consider

👍 / 👎 Definitions of Done

MickinSahni commented 4 years ago

Hey @jenstrickland, is this the extent of the feedback for the Design Intent collaboration? If so, I'd like to groom it with the team and create any additional tickets to track knocking this out.

jenstrickland commented 4 years ago

@MickinSahni This is the extent of the accessibility feedback for the design intent collaboration, given the project timeline. There would normally be additional tickets with feedback for the other practice areas, but they had none and used a comment.

MickinSahni commented 4 years ago

Must items--> https://github.com/department-of-veterans-affairs/va.gov-team/issues/7097

jenstrickland commented 4 years ago

@MickinSahni I just remembered this download link documentation that may be of use, if your team has download links. @1Copenut and I collaborated on defining the accessible download links, and iirc this is going to eventually be in the design system.

MickinSahni commented 4 years ago

@ncksllvn doublecheck that the should and consider items are not already taken care of. if not, groom and prep for prioritization (estimate, milestone, etc.)

ncksllvn commented 4 years ago

Going through this list, noting the ones we need to revisit. Going to follow up against boiling this down further.

VSP

musts

  1. "Apply online" button will need an aria-label or SR-only text to be clear to screen readers.

should

  1. Download links should follow the accessible pattern VSA/VSP accessibility specialists collaborated on
    • Great suggestion.
  2. Current page in the breadcrumb should be bold
    • Not sure I follow exactly what this means (page in the breadcrumb?) but I don't think we're doing that.

consider

  1. Following the date format outlined in our Dates and years content section

VSA

musts

I think we're good here

should

  1. Individual buttons should include an accessible name that matches the displayed text.
  2. Chevron: the > right angle bracket should also have a these attributes
  3. The purpose of a link should be determined from the link text alone or from text together with programmatically determined link context
  4. Accessibility best practices state file download links should provide file size
    • Hm, not sure on the technical feasibility here

consider

  1. Consider that the animation of the link may be distracting or trigger a vestibular disorder, resulting in nausea and headaches.
    • I'm not against this but I'm not sure i understand. We don't have any animations defined for Find Forms...this might be referring to the hover effect on links where the background fades in? I think this is global;
  2. Consider the spacing of the links and buttons, to ensure those with keyboard and other assistive tech can easily select the item they want. Message me and I can share a couple of images of user scenarios.
    • I feel like we're okay as far as spacing goes but we should get clarity on this.
ncksllvn commented 4 years ago

Action items

We should implement these as part of #11453 or after.

  1. "Apply online" button will need an aria-label or SR-only text to be clear to screen readers.
  2. Download links should follow the accessible pattern VSA/VSP accessibility specialists collaborated on
  3. Individual buttons should include an accessible name that matches the displayed text.
  4. Chevron: the > right angle bracket should also have a these attributes
  5. The purpose of a link should be determined from the link text alone or from text together with programmatically determined link context

Discuss

These items we need to clarify and decide on before we can move forward with technically.

  1. Following the date format outlined in our Dates and years content section
    • Currently, our dates look like Form last updated: 03-22-2020. Should this be Form last updated: 03/22/2020, or Form last updated: March 22, 2020?
  2. Accessibility best practices state file download links should provide file size
    • Unless the API provides the file size in the JSON data for each form, I don't think we can do this technically. I glanced at the linked StackOverflow thread, but I don't think that solution work for us.
  3. Consider that the animation of the link may be distracting or trigger a vestibular disorder, resulting in nausea and headaches.
    • This may be calling for a global change - removing the "fade" effect of the background color when links are hovered over
  4. Consider the spacing of the links and buttons, to ensure those with keyboard and other assistive tech can easily select the item they want. Message me and I can share a couple of images of user scenarios.
    • Need clarity
ncksllvn commented 4 years ago

@MickinSahni @jenniferlee-dsva I just circled back to this. Many of these I think we can do in our upcoming work for adding the additional fields into the search results in https://github.com/department-of-veterans-affairs/va.gov-team/issues/11453, but others we need to discuss a bit before implementation

MickinSahni commented 4 years ago

Accounted for in #11453. Archiving this to keep for our records.