Mottie
commented
2 months ago I've got a PR open to move the Supplemental Claim primary phone code into the shared folder, but as I started working on adding a primary phone question to NOD, I encountered a few concerns.
But some background first:
- All of the contact info page code used to live in each of our app's folders.
- NOD & HLR only required a mobile phone number
- Supplemental Claims used to require a home OR mobile phone number, but not both.
- When the code was generalized, and moved into platform, supporting a requirement of home OR mobile became very complicated, so it was made to require BOTH home and mobile
In anticipation of adding a primary phone page to NOD, a PR is open to move the Supplemental Claim primary phone page to the appeals shared folder - that's working fine, but not yet merged. The concern was noted after working on NOD:
- When adding a home phone to the contact info page, we're now locked into the requirement of having both a home & mobile phone defined in their profile
- If the Veteran has an in-progress form, they won't know about the requirement until they try to submit - good thing is that the accordion chapter and page within will highlight and a message stating that the primary phone isn't defined will be visible; so maybe we need to add a redirect back to the contact info page?
- If we add a redirect, should it go the primary phone page if they do have both home & mobile numbers? Or should it go to the contact info page if the home number is missing?
- If we add a redirect, we'll need to add a feature flag so we can test and limit usage until everything is validated
With these concerns, I think we need to further investigate and discuss them before proceeding with implementation. That, and this extra work would change the work estimate.
saderagsdale
eileen-coforma
Value Statement
As a Veteran I want to be able to choose my primary phone number So that I don't have to provide a mobile number if I don't have one
Background Context
In our Supplemental Claim form, we show both the home & mobile phone on the contact information page. Immediately after that page is a question asking if either the home of mobile phone is a primary phone number. Currently in the NOD form, we only show the mobile phone assuming that the Veteran has a mobile phone. They may already be using the same number for both the home & mobile phone, but we still want to give them a choice.
Acceptance Criteria
Tasks
Design and Build Notes
Definition of Ready
Definition of Done