department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Take note of veteran_organizations state and state_code #69317

Open jvcAdHoc opened 9 months ago

jvcAdHoc commented 9 months ago

The veteran_organizations table has two columns related to state:

Because the state column existed before we started, we should leave it alone. That said, it may be helpful for our future selves to leave a note in the code to keep track of this situation.

~Task:~ ~- [ ] determine if we want to keep the original column~

~if we only want the state_code column, then:~ ~- [ ] create a pr to replace all organization state references with state_code and remove state updating in vso_reloader.rb~ ~- [ ] create a migration only pr to remove the original state column~

~It is probably a good idea to reach out the lighthouse dash team to see if there are any downstream effects/consumers.~

oddball-lindsay commented 9 months ago

@jvcAdHoc did the state column exist before we started? if so, @holdenhinkle advises leaving it alone.

jvcAdHoc commented 9 months ago

@oddball-lindsay yes,state existed before we started