NOD | Clean up NOD create request body `example.json` in vets-json-schema

[anniebtran]

Value Statement

As a Developer I want to be able to reference/use the NOD create request body example defined in vets-json-schema So that we have example data to use in tests that is accurate and consistent

Background Context

As discovered in the work to clean up the NOD v2 controller and tests, we found that the mock/example data being used in the original iteration of the request specs was actually using the structure of the response body instead of the request body (see Lighthouse docs for POST /notice_of_disagreements) and this comment for investigation notes. So the goal here is to clean that up and fix that example to have the proper structure. We can reference the v2 Lighthouse docs to make sure we have everything covered.

This should also hopefully clean up the Swagger docs for vets-api (switch to v1 instead of v0 in the https://dev-api.va.gov/v0/apidocs in the "explore" bar at the top of the page)

Out of scope

• Other example data clean up

Tasks

• [ ] Update the example in example.json
• [ ] Determine if there are any additional steps to update the vets-json-schema dependency for vets-api app
• [ ] Determine if any other apps (i.e. vets-website) are impacted by this change
• [ ] Clean up any tests on vets-api that might be impacted by this update
• [ ] Check that v1 Swagger docs are updated locally once the example.json is updated

Definition of Ready

• [ ] We've identified any additional steps to update vets-api to pick up this change
• [ ] We've identified any additional clean up that vets-website might need as a result of this change
• [ ] We've identified any tests that might break from this update

Definition of Done

• [ ] We can see the updated Swagger documentation and it displays the correct request body structure for POST /v1/notice_of_disagreements
• [ ] Our v1 tests can use this updated example and continue to pass

[saderagsdale]

@anniebtran will estimate.

[data-doge]

Closing. Annie tested locally by hardcoding timezone. If our logs show this error reoccuring, we can re-open ticket.

[data-doge]

Woops, closed wrong ticket - ignore please.

[saderagsdale]

@data-doge I changed the status to "Ready for Pickup" and moved it to sprint 44.