department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 205 forks source link

Move health supplies reordering form to My Health route #70757

Open wesrowe opened 11 months ago

wesrowe commented 11 months ago

Description

User story

As an authenticated user, I want to find the form for reordering CPAP/hearing aid supplies/ under /my-health/ in the VAgov IA, so that it's easy to stay oriented and move back up to the MHV landing page if needed.

Notes

Acceptance criteria

Tasks

carlosfelix2 commented 10 months ago

@batemapf Requested that the path be all lowercase.

when your making the change, would please set the new path to my-health/order-hearing-aid-or-cpap-supplies-form? i uppercased the cpap in there and got yelled at by the IA team and have been promising to fix it…for a while :slightly_smiling_face:

carlosfelix2 commented 10 months ago

Links to stage 1 PRs:

carlosfelix2 commented 9 months ago

I found that the migration steps from before have a problem that the vets-website and content-build repos need to be updated at the same time in Stage 2 for that to work. I also found that specifying the same app with different paths in the content-build repo's registry file will result in a virtual redirect to the rootUrl specified in the apps manifest. So, the migration steps are now as follows:

  1. Stage 1 - Pre-setup for the redirect
    • [x] Add the new /my-health/order-hearing-aid-or-cpap-supplies-form path to the reverse React proxy config in the devops repo to open up the new path to the React apps.
    • [x] Add a new React app to the Drupal registry in the content-build repo to point to the new URL, but using the same original app. This will result in the app redirecting itself to the URL specified in the app's manifest file, but note this redirect only works for the root URL.
    • [x] Wait until all changes are deployed to production and verify /my-health/order-hearing-aid-or-cpap-supplies-form redirects to /health-care/order-hearing-aid-or-CPAP-supplies-form.
  2. Stage 2 - Enable the new URL
    • [x] Contact CAIA to do a content audit to replace any of the old links to the new one. File an intake request for CAIA to update any links to the ordering tool. Note that this is only possible if the static page links point to the root of the application and any child links will break until the permanent redirect is in place.
    • [ ] Wait until all changes are deployed to production and verify the links in the static pages were updated.
    • [ ] Change the existing ordering app in the vets-website repo to the new path. Note this will break any links to child paths of the old URL until the next change to the registry is deployed.
    • [ ] Change any static links to the reordering site that exist in the vets-website repo to use the new URL. There are only a few in unit/e2e tests.
    • [ ] Wait until all changes are deployed to production and verify /health-care/order-hearing-aid-or-CPAP-supplies-form redirects to /my-health/order-hearing-aid-or-cpap-supplies-form.
  3. Stage 3 - Make the redirect permanent
    • [ ] Add a new redirect from the old to the new URL in the reverse proxy redirect config of the devops repo.
    • [ ] Remove the old /health-care/order-hearing-aid-or-CPAP-supplies-form path from the reverse React proxy config in the devops repo.
    • [ ] Wait until all changes are deployed to production and verify /health-care/order-hearing-aid-or-CPAP-supplies-form redirects to /my-health/order-hearing-aid-or-cpap-supplies-form.
  4. Stage 4 - Cleanup
    • [ ] Remove the app using the old URL from the registry in the content-build repo.
    • [ ] Wait until all changes are deployed to production and verify /health-care/order-hearing-aid-or-CPAP-supplies-form redirects to /my-health/order-hearing-aid-or-cpap-supplies-form.
wesrowe commented 9 months ago

status at planning mtg: waiting on CAIA for ticket referenced above

sterkenburgsara commented 8 months ago

@carlosfelix2 @wesrowe realizing that the supply re-order form is currently visible to unauth users and this won't work when it migrates to /my-healthsince the entire health portal sits behind authentication. I wrote this up in a Slack post here, but repeating the nuts & bolts below for documentation.

The CPAP & hearing aid batteries supply re-order form is currently visible to unauth users and this won't work when it migrates to /my-health since the entire health portal sits behind authentication. We need the CAIA team to update the /health-care benefit hub pages for both entry points to actually have a sign-in modal in place (currently there is just an action link that routes users to the form even when in an unauth state). If we don't update those, unauth users will be able to see & click that link but will not be able to get to the form.

Relevant pages:

Not only do those pages need sign-in modals in place, but CAIA needs to implement "verify your identity" alerts for any signed-in LOA1/2 users. Only LOA3 users should be routed to the actual form. Also need to ensure this form is removed from our xml index when it migrates, so that it isn't being picked up by crawlers. // cc @mnorthuis

wesrowe commented 8 months ago

A thought on implementation - did we look at changing the login widget that CAIA uses all over the benefit hubs so that every instance has the LOA1 check? or did CAIA do that already?

wesrowe commented 8 months ago

FYSA, CAIA created a ticket for adding login widgets to the entry point pages for this form. I linked that ticket as a dependency for this one; it has to be done before we complete moving the app.

wesrowe commented 8 months ago

Update on CAIA and entry points: CAIA needs a team to implement the login widgets on these entry points. I referred them to Public Websites, the dev team for the benefit hubs.

sterkenburgsara commented 1 month ago

@wesrowe is this unblocked now? I believe Carlos merged the sign-in widget ticket.

// cc @Jenny-yw

carlosfelix2 commented 1 month ago

We are waiting on the identity team to complete the integration into the UI.