Move landing page to isolated app build

[wesrowe]

MAY BE BLOCKED on IA dependency in Medications tool

Description

User story

As a Cartographers team member, I want our landing page to be built in isolation, so that deploys are done quickly and on-demand with less exposure to unrelated flaky CI steps.

Notes

See first comment below for two in-flight PRs.

See steps/discussion here

• each app would have to be moved to its own directory, rather than live under /mhv/
• all shared code in use would have to be either duplicated in the app directory or (ideally) moved under platform

Steps mentioned by Adrian in slack:

• PR to move any used functions from /shared into the app dir
• PR to duplicate the app to the new location and enable isolated app builds
• PR to update app registry (in content-build) to move to the new app location
• PRs to remove the old app dir and clean up the app registry

Related docs

• https://depo-platform-documentation.scrollhelp.site/developer-docs/isolated-application-builds
• https://depo-platform-documentation.scrollhelp.site/developer-docs/continuous-deployment

Acceptance criteria

• Landing page CI is isolated/independent
• Cartographers' steps and learnings are documented to help health tool teams follow our path

Tasks

• [x] Determine how we should remove /my-health/about-medications as a cross-app dependency, understanding that the URL was chosen for IA reasons, per #issuecomment-1836275393 Veteran flow through it, including removal of the app from codebase~~
• [x] Refactor code within src/platform to not import from src/applications/mhv/landing-page. department-of-veterans-affairs/vets-website#27006

[dcloud]

Existing tickets:

• https://github.com/department-of-veterans-affairs/va.gov-team/issues/53811
• https://github.com/department-of-veterans-affairs/va.gov-team/issues/61867

I think the main difference now is the recommendation to move the app to a different directory, since the Platform bug that blocked this work, https://github.com/department-of-veterans-affairs/va.gov-team/issues/58176, seems unlikely to get fixed

[radavis]

Documentation on Isolated Application Builds: https://depo-platform-documentation.scrollhelp.site/developer-docs/isolated-application-builds

[radavis]

There are some issues we will need to address before taking on this ticket:

/my-health/about-medications

Currently, there is code within the MHV Landing Page that routes to a component within Medications. The Medications team/IA wanted the above URL path. Because of technical limitations and time constraints, we did a cross-app import and mounted their component within our routes file. We will need to address this in order to make our landing page an isolated application.

Potential Options:

• Move the Medications Landing Page component into mhv/landing-page -- not ideal
• Move the Medications app code into the MHV Landing Page app code folder -- It's a better solution than the above. However, the Medications team will no longer have their own application folder. Their team would have to OK this change.
• Move About Medications to a path underneath /my-health/medications. e.g. -- /my-health/medications/about, and redirect requests for /my-health/about-medications to the new path.

Address shared code with the Mega Menu:

Refactor the following files to avoid importing from application/mhv/landing-page. I believe importing our manifest is OK (yarn check-app-imports --app-folders mhv/landing-page will tell us), but other imports from our landing page should be refactored out.

• src/platform/site-wide/mega-menu/containers/Main.jsx
• src/platform/site-wide/user-nav/components/MyHealthLink.jsx
• src/platform/site-wide/mega-menu/tests/my-health-link/mega-menu.my-health.cypress.spec.js
• src/platform/site-wide/mega-menu/tests/my-va-link/mega-menu.my-va.cypress.spec.js -- using our manifest, but code is for the /my-va link
• src/platform/site-wide/user-nav/tests/e2e/my-health-link/user-nav.my-health.cypress.spec.js

Relevant Slack conversation

Relevant Medications/IA documentation

[sterkenburgsara]

Update: related thread in Medications Slack channel to gauge timeline for moving /about-medicationscontent to a new URL to unblock this work.

[wesrowe]

Refinement notes:

• Way forward: can move about-medications content into Drupal, would solve this
  • need Coulton, Kay and CAIA confirmation on approval and timing
• Consult with Danielle to ensure we have a viable Drupal template

[carlosfelix2]

Help a developer meeting to figure out steps to isolated our application:

1. Copy (do not move) MHV landing page app folder to the applications folder level, so we can run the check app imports script. This includes refactoring/copying the use DataDogRUM code from the shared folder. This requires a new appName for step 5. Possibility of using git move to move the files to the new location, then make a copy of the files to the old location, so we can retain the history of the files in the new location.
2. Copy medications landing page code (and dependencies) into the MHV landing page location.
3. Enable isolated app for the new MHV landing page location.
4. Deploy changes to production. Must verify it is in production before proceeding.
5. Update content-build repo to point to new MHV landing page location. Must verify content-build changes are deployed to production before proceeding.
6. Remove old MHV landing page location from repo.

Note: Probably need another ticket to track move of the landing page to Drupal.

[dcloud]

Per Slack:

Update: cannot use Drupal for authenticated content (it only works for publicly viewable / unauth pages).

We can still temporarily copy the medication landing page, but would need a different approach for where the content will move to in the future since Drupal is out:

1. It can be its own app… 🙁
2. It moves URLs and lives at a path under /my-health/medications/, such as /my-health/medications/about. This would involve changes to the MHV medications app to add that page at a route, plus a redirect in our own app to the new URL

[dcloud]

It's done?!